When running CI scripts locally, they attempt to use a $DEPENDS_DIR/$HOST directory even NO_DEPENDS=1 is provided.
This PR fixes this broken behavior.
ci: Use `CONFIG_SITE` variable and `--prefix` option properly #26683
pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:221210-ci-dep changing 3 files +7 −4-
hebasto commented at 7:21 PM on December 10, 2022: member
-
574e50addf
ci: Use `CONFIG_SITE` variable and `--prefix` option properly
This change fixes scripts when they are being run locally with a pre- existed `$DEPENDS_DIR/$HOST` directory.
-
DrahtBot commented at 7:21 PM on December 10, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers Stale ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Dec 10, 2022
-
hebasto commented at 12:16 PM on December 19, 2022: member
Friendly ping @MarcoFalke :)
- maflcko approved
-
- fanquake approved
-
fanquake commented at 5:12 PM on December 20, 2022: member
ACK 574e50addf8c65a3a9e0f2d8e933c147d1e93932
like the valgrind build picks up a previous depends build, like msan-depends?
I checked that running back-to-back CI builds with a depends (MSAN) followed by non-depends (Valgrind) no-longer has build issues. I think https://github.com/fanquake/bitcoin/commit/6cceb7a4c2efbda8d3f763f3b3805a14ebe10daf could also be included here?
-
ci: remove --prefix from msan job d3a84347e8
-
hebasto commented at 5:18 PM on December 20, 2022: member
I think fanquake@6cceb7a could also be included here?
Added.
- maflcko approved
- bitcoin deleted a comment on Dec 20, 2022
- fanquake merged this on Dec 21, 2022
- fanquake closed this on Dec 21, 2022
- hebasto deleted the branch on Dec 21, 2022
- sidhujag referenced this in commit ae41bcbec3 on Dec 21, 2022
- bitcoin locked this on Dec 21, 2023
