Since commit 3340dbadd38f5624642cf0e14dddbe6f83a3863b ("Remove -zapwallettxes"), the FindWalletTx helper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly.
refactor: walletdb: drop unused `FindWalletTx` parameter and rename #26702
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202212-walletdb-refactor_simplify_findwallettx changing 2 files +5 −8-
theStack commented at 12:20 AM on December 15, 2022: contributor
-
f496528556
walletdb: refactor: drop unused `FindWalletTx` parameter and rename
Since commit 3340dbadd38f5624642cf0e14dddbe6f83a3863b ("Remove -zapwallettxes"), the `FindWalletTx` helper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly. -
DrahtBot commented at 12:20 AM on December 15, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK S3RK, vincenzopalazzo, achow101 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #25766 (wallet: Include a signature with encrypted keys to mitigate a wallet scam by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
S3RK commented at 8:21 AM on December 15, 2022: contributor
code review ACK f496528556a67107d3d75d9c2ae345f7f4565d77
- maflcko added the label Refactoring on Dec 15, 2022
- maflcko removed the label Refactoring on Dec 15, 2022
- maflcko renamed this:
walletdb: refactor: drop unused `FindWalletTx` parameter and rename
refactor: walletdb: drop unused `FindWalletTx` parameter and rename
on Dec 15, 2022 - DrahtBot added the label Refactoring on Dec 15, 2022
- vincenzopalazzo approved
-
vincenzopalazzo commented at 9:10 PM on December 17, 2022: none
- maflcko assigned achow101 on Dec 19, 2022
-
achow101 commented at 4:46 PM on January 3, 2023: member
ACK f496528556a67107d3d75d9c2ae345f7f4565d77
- achow101 referenced this in commit 1e6b384d59 on Jan 3, 2023
-
fanquake commented at 4:57 PM on January 3, 2023: member
This has been merged.
- fanquake closed this on Jan 3, 2023
- theStack deleted the branch on Jan 3, 2023
- sidhujag referenced this in commit 38cf5342d8 on Jan 4, 2023
- bitcoin locked this on Jan 3, 2024
Labels