This PR adds test coverage for the following error: https://github.com/bitcoin/bitcoin/blob/cb32328d1b80d0ccd6eb9532bd8fe4e0a4de385e/src/wallet/rpc/addresses.cpp#L332-L334
test: call `keypoolrefill` with priv key disabled should throw an error #26723
pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2022-12-keypool-error-privatekey changing 1 files +3 −0-
brunoerg commented at 8:25 PM on December 18, 2022: contributor
-
DrahtBot commented at 8:25 PM on December 18, 2022: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK aureleoules If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Dec 18, 2022
-
test: call `keypoolrefill` with private keys disabled should throw an error ec63a4892e
- brunoerg force-pushed on Dec 19, 2022
-
aureleoules commented at 2:10 PM on December 19, 2022: member
ACK ec63a4892e67fdc6c0c464e6d4cffcd3eb48941c
- maflcko referenced this in commit 8ab19237e1 on Dec 19, 2022
-
fanquake commented at 2:29 PM on December 19, 2022: member
Closing, as this has been merged. However wasn't this already covered in https://github.com/bitcoin/bitcoin/blob/8ab19237e11ee510a7941a4ab429471b29cccd69/test/functional/wallet_watchonly.py#L57 ?
- fanquake closed this on Dec 19, 2022
-
brunoerg commented at 2:32 PM on December 19, 2022: contributor
Closing, as this has been merged. However wasn't this already covered in https://github.com/bitcoin/bitcoin/blob/8ab19237e11ee510a7941a4ab429471b29cccd69/test/functional/wallet_watchonly.py#L57 ?
No, the error message is the same but the commands are different.
-
aureleoules commented at 3:08 PM on December 19, 2022: member
I also verified that this was not already covered by looking at https://marcofalke.github.io/btc_cov/total.coverage/src/wallet/rpc/addresses.cpp.gcov.html.
- sidhujag referenced this in commit 5d2a74dddb on Dec 19, 2022
- bitcoin locked this on Dec 19, 2023
Contributors
Labels