More bestblock records in wallets #2682

1. 
   sipa commented at 7:04 PM on May 22, 2013: member

   Write bestblock records in wallets:

   • Every 20160 blocks synced, no matter what (before: none during IBD)
   • Every 144 blocks after IBD (before: for every block, slow)
   • When creating a new wallet (new)
   • At shutdown (new)

   This should result in far fewer spurious rescans.

   To correct all previously missed rescans, we should probably also once change the bestblock record name (suggested by gmaxwell), to force a single rescan once for every wallet. As this is likely to be annoying for almost all, and most that have missed funds in the past have already done a full rescan already, this is perhaps controversial and not included in this pullreq.

   Should close #2676 (but I haven't tested that).

2. More bestblock records in wallets

   Write bestblock records in wallets:
   * Every 20160 blocks synced, no matter what (before: none during IBD)
   * Every 144 blocks after IBD (before: for every block, slow)
   * When creating a new wallet
   * At shutdown
   
   This should result in far fewer spurious rescans.

   95c7db3dbf
3. 
   gmaxwell commented at 7:20 PM on May 22, 2013: contributor

   Mostly I think it's essential that we do a release with a forced rescan prior to doing a release that supports turning on pruning that will make rescans infeasible (or at least a slow network traffic generating event).

4. 
   BitcoinPullTester commented at 7:33 PM on May 22, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/95c7db3dbf4012dd02e5f1f30e6d982341facaa6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

5. 
   gavinandresen commented at 7:46 PM on May 22, 2013: contributor

   ACK.

   Synced testnet chain while watching bestblock record in wallet.dat, it changed at the right times.

6. 
   gmaxwell commented at 9:00 PM on May 22, 2013: contributor

   ACK.

   In valgrind, tried three different wallets, including old ones with no bestblock record and a empty one. Tested starts and stops, and a reindex. Looks okay and does not rescan on a new wallet.

7. gmaxwell referenced this in commit 95c2ba1689 on May 22, 2013
8. gmaxwell merged this on May 22, 2013
9. gmaxwell closed this on May 22, 2013

   ---

10. laudney referenced this in commit 02e1e23950 on Mar 19, 2014
11. DrahtBot locked this on Sep 8, 2021

Milestone
v0.8.2