build: allow NO_BOOST=1 & NO_LIBEVENT=1 in depends #26833

fanquake commented at 9:26 AM on January 6, 2023: member

Prerequisite for removing install_db4.sh. So we can invoke make -C depends/ NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_NATPMP=1 NO_ZMQ=1 NO_UPNP=1 NO_USDT=1 and get a prefix with only bdb headers/libs.

DrahtBot commented at 9:26 AM on January 6, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto
Concept ACK	murrayn

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#26834 (contrib: remove install_db4.sh by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Jan 6, 2023

hebasto commented at 9:31 AM on January 6, 2023: member

Concept ACK.

fanquake force-pushed on Jan 6, 2023

murrayn commented at 11:30 AM on January 6, 2023: contributor

Concept ACK

in depends/packages/packages.mk:1 in 67c472c20d outdated

   0 | @@ -1,4 +1,8 @@
   1 | -packages:=boost libevent
   2 | +packages:=

TheCharlatan commented at 11:09 AM on January 10, 2023:

Concept ACK Nit: I guess this could be removed here and packages be defined in depends/Makefile. Not sure if this is actually better though.

fanquake commented at 12:34 PM on January 14, 2023:

I think we'll just leave this here for now.

build: allow NO_BOOST=1 in depends 0cee156eee

build: allow NO_LIBEVENT=1 in depends 7fdeb80441

in depends/Makefile:171 in 67c472c20d outdated

 167 | @@ -162,7 +168,7 @@ zmq_packages_$(NO_ZMQ) = $(zmq_packages)
 168 |  multiprocess_packages_$(MULTIPROCESS) = $(multiprocess_packages)
 169 |  usdt_packages_$(NO_USDT) = $(usdt_$(host_os)_packages)
 170 |  
 171 | -packages += $($(host_arch)_$(host_os)_packages) $($(host_os)_packages) $(qt_packages_) $(wallet_packages_) $(upnp_packages_) $(natpmp_packages_) $(usdt_packages_)
 172 | +packages += $($(host_arch)_$(host_os)_packages) $($(host_os)_packages) $(boost_packages) $(libevent_packages) $(qt_packages_) $(wallet_packages_) $(upnp_packages_) $(natpmp_packages_) $(usdt_packages_)

hebasto commented at 6:20 PM on January 13, 2023:

Shouldn't be

packages += $($(host_arch)_$(host_os)_packages) $($(host_os)_packages) $(boost_packages_) $(libevent_packages_) $(qt_packages_) $(wallet_packages_) $(upnp_packages_) $(natpmp_packages_) $(usdt_packages_)

?

fanquake commented at 12:35 PM on January 14, 2023:

Changed.

fanquake force-pushed on Jan 14, 2023

hebasto approved

hebasto commented at 3:17 PM on January 14, 2023: member

ACK 7fdeb80441f451c8983632329594f4903af92729, tested on Ubuntu 22.04:

$ cd depends
$ make clean
$ make NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 NO_USDT=1 NO_BOOST=1 NO_LIBEVENT=1
copying packages:
to: /home/hebasto/git/bitcoin/depends/x86_64-pc-linux-gnu

maflcko added the label DrahtBot Guix build requested on Jan 16, 2023

fanquake commented at 1:10 PM on January 16, 2023: member

Guix Build:

3f3d70a062b9e5524e2276dd5658a6b6d61c9dc6a7bc78f494852c602169b129  guix-build-7fdeb80441f4/output/aarch64-linux-gnu/SHA256SUMS.part
fdbbe581d0a0c1f223eea02808abcc060f3f739de68900b87b2afbdef1ff5269  guix-build-7fdeb80441f4/output/aarch64-linux-gnu/bitcoin-7fdeb80441f4-aarch64-linux-gnu-debug.tar.gz
73d08e1a327c75282ef6ab65718567fb2b97115c92e5aec5a38354d149ff7cad  guix-build-7fdeb80441f4/output/aarch64-linux-gnu/bitcoin-7fdeb80441f4-aarch64-linux-gnu.tar.gz
e2aab27790676306dfb281720464bc4a07331538fd11330e47b66b477cff1d48  guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/SHA256SUMS.part
a1de1d253bf64607fcb40aaf3a2e2c3f055c703c1c177ceda08ef079fcd5041f  guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/bitcoin-7fdeb80441f4-arm-linux-gnueabihf-debug.tar.gz
027126dcd44edd9d7dfeedda1c53014ed8bc0310aad8b9d964368d1d028c9fa9  guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/bitcoin-7fdeb80441f4-arm-linux-gnueabihf.tar.gz
97b970c788750418addb7aff1b50a3a1389eb7e4e8d20ed0f779023842eef941  guix-build-7fdeb80441f4/output/arm64-apple-darwin/SHA256SUMS.part
430936a60cd8638a7b85608015c01aab18cc49d66c9d94fc3d9f70cbf99f6fd5  guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin-unsigned.dmg
359cecf3468caea55449d90ac18ed3faaf271df7a697f58a76ed6ea98d7df5fa  guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin-unsigned.tar.gz
c44b99dcbbb8c4004e676c5ff1e1f8d4a70443f7f62a91c38fcae661a9cbdaf3  guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin.tar.gz
f127cb319db1ae6360b5668b31b5a5882882b3a493b82e18b9219a2c9dbfd530  guix-build-7fdeb80441f4/output/dist-archive/bitcoin-7fdeb80441f4.tar.gz
b3059b80f8485a710010311c0ee298664184328f7a089ea012c3b734023640ee  guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/SHA256SUMS.part
a688a22fc329b2c327d588d33f5e20f68eb4e1e37b15ef831d076797172feba4  guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/bitcoin-7fdeb80441f4-powerpc64-linux-gnu-debug.tar.gz
52bf8c3dd7ea543de91e2a5c82211bbf32adf238858b3923bc2c3fd705268fcb  guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/bitcoin-7fdeb80441f4-powerpc64-linux-gnu.tar.gz
4597b1d1ece10b6da6984faecd85427ac9fbd4c8efbfa4d8fe9b62599bea1028  guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/SHA256SUMS.part
334c2cf241e32338fc492d94ece26a2d425580190a23087b8313a868ed961d13  guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/bitcoin-7fdeb80441f4-powerpc64le-linux-gnu-debug.tar.gz
b24170d8bb5c77470b01129cc19d02aa4cc8eb28009232c7e518955748aada34  guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/bitcoin-7fdeb80441f4-powerpc64le-linux-gnu.tar.gz
a0c1a5004d96bc38dc470d3e92b790ebe8eee26b7f96dddfb02ea905de53aebb  guix-build-7fdeb80441f4/output/riscv64-linux-gnu/SHA256SUMS.part
a92659662688791bcca689549540a193aca02a794d53c7898a063a93c62cc068  guix-build-7fdeb80441f4/output/riscv64-linux-gnu/bitcoin-7fdeb80441f4-riscv64-linux-gnu-debug.tar.gz
0771fe12bfbd8af94c70592bc4b76fec23545c7930cb2aedf752c02f5f16ee91  guix-build-7fdeb80441f4/output/riscv64-linux-gnu/bitcoin-7fdeb80441f4-riscv64-linux-gnu.tar.gz
2d42ff20b8850400eb1fcf78e0db720553321948557b13c113b279db55684c3c  guix-build-7fdeb80441f4/output/x86_64-apple-darwin/SHA256SUMS.part
f68b40f13cc109dfc926f008139410719aca0ee1674fc2d346599d9179949d7b  guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin-unsigned.dmg
fa5fb50c7555e719021e44b9167da643fc12ce661639115940d1e2353d8b2c0f  guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin-unsigned.tar.gz
6e6a95690f8adc9680b5ca80c57216a6962b88ed9509adfb99166fd77d4a3cfe  guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin.tar.gz
dc82f7c14639e16e843e14b0fe2993f89882f29a7ceca06ef95e04ac55557523  guix-build-7fdeb80441f4/output/x86_64-linux-gnu/SHA256SUMS.part
10ad5fbb305c005621fb8f59b2046e9940cf1caaac35ca20d92c3d74f062ad10  guix-build-7fdeb80441f4/output/x86_64-linux-gnu/bitcoin-7fdeb80441f4-x86_64-linux-gnu-debug.tar.gz
67f1e033dc30cc70eb22df65877662fe94d5f03cba6c63ac0d178ac3829926e5  guix-build-7fdeb80441f4/output/x86_64-linux-gnu/bitcoin-7fdeb80441f4-x86_64-linux-gnu.tar.gz
07b8fcf86a8b39bdf6830b4f12cdbc2d45469a69800e026b257fa9d6f6d0cbb8  guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/SHA256SUMS.part
f48e5424ac6b6eca3d59b80497590d66315da23edd12b89b5f9e8d5ceea9b9b0  guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-debug.zip
040bb2b6319b0a61449ee332e69096467360b7e91e105e538c3dfec8bc542f10  guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-setup-unsigned.exe
56dce754e737fd3be2ffaea48d3d31f8d04c1e65f53d2e233af2f56c6a16d126  guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-unsigned.tar.gz
1ede72369c34930f98dc6e394f4ca02bd39c4dc8fc84a855d65bcd45a5d33703  guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64.zip

DrahtBot commented at 9:14 PM on January 16, 2023: contributor

Guix builds

File	commit 08d2a3ab4b6982ee38f3e9566a0f7629c40b1b34<br>(master)	commit b08e27da99148c3975572d696a6d55559f994db0<br>(master and this pull)
SHA256SUMS.part	`7d5e143f7d90f027...`	`01ade616a6c717f8...`
*-aarch64-linux-gnu-debug.tar.gz	`a80d5355f3b85cda...`	`13190712ed2247c4...`
*-aarch64-linux-gnu.tar.gz	`f1de0249ac80340b...`	`d5a706789a048914...`
*-arm-linux-gnueabihf-debug.tar.gz	`431504e8ca043700...`	`6c6814cf6718cabb...`
*-arm-linux-gnueabihf.tar.gz	`a99f92f87a00fc1e...`	`7042e515eb602dfa...`
*-arm64-apple-darwin-unsigned.dmg	`bba05a4c35e3920e...`	`9975ecdd97d96401...`
*-arm64-apple-darwin-unsigned.tar.gz	`f60f1a082260dc67...`	`4aa83023e3d89f0c...`
*-arm64-apple-darwin.tar.gz	`5ad59eb344e02c96...`	`0b24a89d5b75c7b2...`
*-powerpc64-linux-gnu-debug.tar.gz	`f956c3880d6513dc...`	`f797ce36591e681d...`
*-powerpc64-linux-gnu.tar.gz	`1dfbdd0d4197c483...`	`560796eafd8823f2...`
*-powerpc64le-linux-gnu-debug.tar.gz	`053d30dd5f30d38c...`	`3179e2982cd31a9a...`
*-powerpc64le-linux-gnu.tar.gz	`88a502ad0591fde2...`	`6394e1af29ab6c7f...`
*-riscv64-linux-gnu-debug.tar.gz	`e183757fd871ab78...`	`a0daae7c83edf95a...`
*-riscv64-linux-gnu.tar.gz	`c954250e8f672551...`	`c8e74a0fffdca4d7...`
*-win64-debug.zip	`22d05bbb28dfcd6d...`	`31fe874d8e979169...`
*-win64-setup-unsigned.exe	`0752a9a9e8a83b04...`	`4714f4a6c10e92cd...`
*-win64-unsigned.tar.gz	`ceb47016c5a9542d...`	`b45f2e961b6a78ef...`
*-win64.zip	`0960b0c57ca3d73e...`	`13f52b8a4795b7a3...`
*-x86_64-apple-darwin-unsigned.dmg	`9214af76a0618dbd...`	`cae5ede0defe3536...`
*-x86_64-apple-darwin-unsigned.tar.gz	`e6ef1d38c4b1f8b5...`	`e7cf42fde9fadf71...`
*-x86_64-apple-darwin.tar.gz	`4b715020b5db07a8...`	`dd218194a9802b8a...`
*-x86_64-linux-gnu-debug.tar.gz	`a569f4ba59d3a836...`	`5d994de8c2a235cb...`
*-x86_64-linux-gnu.tar.gz	`4f2948f4f3f2b730...`	`4e4d470716254b91...`
*.tar.gz	`057198d2b65d888c...`	`cd1c2e446189583e...`
guix_build.log	`03daa980e0cab5b2...`	`39dcc01c86dc4040...`
guix_build.log.diff		`aa0fe56158ba4f86...`

DrahtBot removed the label DrahtBot Guix build requested on Jan 16, 2023

fanquake merged this on Jan 17, 2023

fanquake closed this on Jan 17, 2023

fanquake deleted the branch on Jan 17, 2023

hebasto commented at 9:52 AM on January 17, 2023: member

I've just realized that https://github.com/bitcoin/bitcoin/blob/master/depends/README.md#dependency-options needs to be updated with new NO_BOOST and NO_LIBEVENT options.

fanquake referenced this in commit d700aa6251 on Jan 17, 2023

fanquake commented at 10:20 AM on January 17, 2023: member

updated with new NO_BOOST and NO_LIBEVENT options.

I don't think it matters that much, as standalone, they aren't really useful. Have added then in 26834 in any case.

sidhujag referenced this in commit dc47739704 on Jan 17, 2023

fanquake referenced this in commit 14ce84388f on Jan 18, 2023

achow101 referenced this in commit 483a4bb819 on Jan 27, 2023

bitcoin locked this on Jan 17, 2024