refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc #26840

pull KolbyML wants to merge 3 commits into bitcoin:master from KolbyML:refactor-imports changing 4 files +803 −624
  1. KolbyML commented at 1:24 AM on January 7, 2023: contributor

    This is a wallet rpc refactor from my gui pr https://github.com/bitcoin-core/gui/pull/650

    I was told by a contributor I should make a pr here for anything not in src/qt except for makefile/.ui stuff

    So this pr refactors the RPC code so that it can be used through interfaces so there isn't a ton of code duplication more details would be in my bitcoin-core/gui pr.

    For context this is apart of my Summer of Bitcoin project achow101 was my mentor.

  2. DrahtBot commented at 1:24 AM on January 7, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29675 (wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys by achow101)
    • #29280 (Implement OP_CHECKTEMPLATEVERIFY by reardencode)
    • #29136 (wallet: addhdkey RPC to add just keys to wallets via new void(KEY) descriptor by achow101)
    • #29050 (Add OP_TXHASH and OP_CHECKTXHASHVERIFY opcodes by stevenroose)
    • #28336 (rpc: parse legacy pubkeys consistently with specific error messages by theStack)
    • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
    • #27351 (wallet: add seeds argument to importdescriptors by apoelstra)
    • #27286 (wallet: Keep track of the wallet's own transaction outputs in memory by achow101)
    • #25979 ([WIP] wallet: standardize change output detection process by furszy)
    • #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Refactoring on Jan 7, 2023
  4. KolbyML marked this as a draft on Jan 7, 2023
  5. KolbyML force-pushed on Jan 7, 2023
  6. KolbyML force-pushed on Jan 7, 2023
  7. KolbyML force-pushed on Jan 7, 2023
  8. KolbyML force-pushed on Jan 7, 2023
  9. KolbyML force-pushed on Jan 7, 2023
  10. KolbyML marked this as ready for review on Jan 7, 2023
  11. DrahtBot added the label Needs rebase on Jan 10, 2023
  12. KolbyML force-pushed on Jan 12, 2023
  13. KolbyML force-pushed on Jan 12, 2023
  14. KolbyML force-pushed on Jan 12, 2023
  15. KolbyML force-pushed on Jan 12, 2023
  16. KolbyML force-pushed on Jan 12, 2023
  17. DrahtBot removed the label Needs rebase on Jan 12, 2023
  18. DrahtBot added the label Needs rebase on Jan 30, 2023
  19. fanquake commented at 10:46 AM on February 16, 2023: member

    @achow101 any thoughts on the best way/time to merge this? Conflicting with a lot of other changes.

  20. KolbyML force-pushed on Feb 19, 2023
  21. KolbyML force-pushed on Feb 19, 2023
  22. DrahtBot removed the label Needs rebase on Feb 19, 2023
  23. DrahtBot added the label Needs rebase on Apr 12, 2023
  24. KolbyML force-pushed on Apr 12, 2023
  25. DrahtBot removed the label Needs rebase on Apr 12, 2023
  26. DrahtBot added the label Needs rebase on Apr 12, 2023
  27. KolbyML force-pushed on Apr 12, 2023
  28. KolbyML force-pushed on Apr 12, 2023
  29. DrahtBot removed the label Needs rebase on Apr 12, 2023
  30. refactor: importpubkey, importprivkey, and importaddress rpc 9b30d90bfa
  31. refactor: importmulti rpc e4414a28e9
  32. refactor: importdescriptors rpc 20b19e7423
  33. KolbyML force-pushed on May 2, 2023
  34. DrahtBot added the label CI failed on Aug 29, 2023
  35. DrahtBot commented at 8:34 PM on September 4, 2023: contributor

    Needs rebase if still relevant

  36. DrahtBot marked this as a draft on Sep 10, 2023
  37. KolbyML commented at 12:37 AM on March 20, 2024: contributor

    closing due to https://github.com/bitcoin-core/gui/pull/650#issuecomment-2008412091

  38. KolbyML closed this on Mar 20, 2024
  39. bitcoin locked this on Mar 20, 2025
Contributors
KolbyMLDrahtBotfanquake
Labels
RefactoringCI failed
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me