Instead of referring to a fixed line number to a file in master (which is obviously always quickly outdated), use a permalink tied to the latest commit.
doc: net: fix link to onion address encoding scheme [ONIONADDRESS] #26864
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202301-doc-fix_torspec_link changing 1 files +1 −1-
theStack commented at 1:51 PM on January 10, 2023: contributor
-
3076f1815d
doc: net: fix link to onion address encoding scheme [ONIONADDRESS]
Instead of referring to a fixed line number to a file in master (which is obviously always quickly outdated), use a permalink tied to the latest commit.
-
DrahtBot commented at 1:51 PM on January 10, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK vasild If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Docs on Jan 10, 2023
- vasild approved
-
vasild commented at 4:05 PM on January 10, 2023: contributor
ACK 3076f1815d64f448aa9dff6e48e07004f42ac0fc
Thanks!
- maflcko referenced this in commit b264410e01 on Jan 10, 2023
-
fanquake commented at 4:18 PM on January 10, 2023: member
This has been merged.
- fanquake closed this on Jan 10, 2023
- theStack deleted the branch on Jan 10, 2023
- sidhujag referenced this in commit 18be025016 on Jan 10, 2023
-
vasild commented at 8:12 AM on January 11, 2023: contributor
Why a change to
src/netaddress.cppwas merged to https://github.com/bitcoin-core/gui? -
fanquake commented at 8:15 AM on January 11, 2023: member
It wasn't. GitHub is broken.
-
maflcko commented at 8:55 AM on January 11, 2023: member
https://github.com/bitcoin/bitcoin and https://github.com/bitcoin-core/gui are mirrors of the monotree, so all changes that are merged into the monotree will be mirrored in both places.
- bitcoin locked this on Jan 11, 2024
