test: skip sqlite3 tests if it isn't available #26882

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:func_tests_check_import_sqlite changing 2 files +13 −1

fanquake commented at 1:28 PM on January 12, 2023: member

Fixes #26819. Related too #26873, which adds the missing documentation.
fanquake added the label Tests on Jan 12, 2023
DrahtBot commented at 1:28 PM on January 12, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK brunoerg

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
test: skip sqlite3 tests if it isn't available
Fixes #26819. Related too #26873.
eea73d465e

Type	Reviewers
ACK	brunoerg

in test/functional/wallet_descriptor.py:34 in 2deb6ac321 outdated

  26 | @@ -27,6 +27,7 @@ def set_test_params(self):
  27 |      def skip_test_if_missing_module(self):
  28 |          self.skip_if_no_wallet()
  29 |          self.skip_if_no_sqlite()
  30 | +        self.skip_if_no_py_sqlite3()

maflcko commented at 1:35 PM on January 12, 2023:

Needs try-catch in line 2 of this file

try:
    import sqlite3
except ImportError:
    pass

fanquake commented at 1:45 PM on January 12, 2023:

Added.

fanquake force-pushed on Jan 12, 2023
brunoerg approved

brunoerg commented at 12:49 PM on January 13, 2023: contributor

ACK eea73d465e5356e9b8d8f41c4a797b5a5aaa63af

Removed sqlite3 and ran the test:

2023-01-13T12:48:05.992000Z TestFramework (WARNING): Test Skipped: sqlite3 module not available.
2023-01-13T12:48:06.047000Z TestFramework (INFO): Stopping nodes
2023-01-13T12:48:06.047000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_bb6sbr9w on exit
2023-01-13T12:48:06.047000Z TestFramework (INFO): Test skipped

With sqlite3:

2023-01-13T12:47:35.815000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_lfqi98qf
2023-01-13T12:47:36.295000Z TestFramework (INFO): Making a descriptor wallet
2023-01-13T12:47:36.335000Z TestFramework (INFO): Checking wallet info
2023-01-13T12:47:36.335000Z TestFramework (INFO): Test that getnewaddress and getrawchangeaddress work
2023-01-13T12:47:36.420000Z TestFramework (INFO): Test sending and receiving
2023-01-13T12:47:36.422000Z TestFramework (INFO): Test disabled RPCs
2023-01-13T12:47:36.427000Z TestFramework (INFO): Test encryption
2023-01-13T12:47:36.886000Z TestFramework (INFO): Test that getnewaddress still works after keypool is exhausted in an encrypted wallet
2023-01-13T12:47:37.107000Z TestFramework (INFO): Test that unlock is needed when deriving only hardened keys in an encrypted wallet
2023-01-13T12:47:37.286000Z TestFramework (INFO): Test born encrypted wallets
2023-01-13T12:47:37.699000Z TestFramework (INFO): Test blank descriptor wallets
2023-01-13T12:47:37.701000Z TestFramework (INFO): Test descriptor wallet with disabled private keys
2023-01-13T12:47:37.703000Z TestFramework (INFO): Test descriptor exports
2023-01-13T12:47:37.740000Z TestFramework (INFO): Testing descriptor address type for legacy external
2023-01-13T12:47:37.741000Z TestFramework (INFO): Testing the same descriptor is returned for address type legacy external
2023-01-13T12:47:37.749000Z TestFramework (INFO): Testing import of exported legacy descriptor
2023-01-13T12:47:37.764000Z TestFramework (INFO): Testing descriptor address type for p2sh-segwit external
2023-01-13T12:47:37.765000Z TestFramework (INFO): Testing the same descriptor is returned for address type p2sh-segwit external
2023-01-13T12:47:37.774000Z TestFramework (INFO): Testing import of exported p2sh-segwit descriptor
2023-01-13T12:47:37.789000Z TestFramework (INFO): Testing descriptor address type for bech32 external
2023-01-13T12:47:37.790000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32 external
2023-01-13T12:47:37.798000Z TestFramework (INFO): Testing import of exported bech32 descriptor
2023-01-13T12:47:37.814000Z TestFramework (INFO): Testing descriptor address type for bech32m external
2023-01-13T12:47:37.814000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32m external
2023-01-13T12:47:37.824000Z TestFramework (INFO): Testing import of exported bech32m descriptor
2023-01-13T12:47:37.844000Z TestFramework (INFO): Testing descriptor address type for legacy internal
2023-01-13T12:47:37.845000Z TestFramework (INFO): Testing the same descriptor is returned for address type legacy internal
2023-01-13T12:47:37.852000Z TestFramework (INFO): Testing import of exported legacy descriptor
2023-01-13T12:47:37.867000Z TestFramework (INFO): Testing descriptor address type for p2sh-segwit internal
2023-01-13T12:47:37.868000Z TestFramework (INFO): Testing the same descriptor is returned for address type p2sh-segwit internal
2023-01-13T12:47:37.876000Z TestFramework (INFO): Testing import of exported p2sh-segwit descriptor
2023-01-13T12:47:37.891000Z TestFramework (INFO): Testing descriptor address type for bech32 internal
2023-01-13T12:47:37.892000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32 internal
2023-01-13T12:47:37.899000Z TestFramework (INFO): Testing import of exported bech32 descriptor
2023-01-13T12:47:37.914000Z TestFramework (INFO): Testing descriptor address type for bech32m internal
2023-01-13T12:47:37.915000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32m internal
2023-01-13T12:47:37.924000Z TestFramework (INFO): Testing import of exported bech32m descriptor
2023-01-13T12:47:37.944000Z TestFramework (INFO): Test that loading descriptor wallet containing legacy key types throws error
2023-01-13T12:47:38.041000Z TestFramework (INFO): Stopping nodes
2023-01-13T12:47:38.152000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_lfqi98qf on exit
2023-01-13T12:47:38.152000Z TestFramework (INFO): Tests successful

maflcko merged this on Jan 13, 2023
maflcko closed this on Jan 13, 2023
fanquake deleted the branch on Jan 13, 2023
sidhujag referenced this in commit b336c87b7b on Jan 13, 2023
bitcoin locked this on Jan 13, 2024

Contributors

Labels

Linked (view graph)

#26819 test: sqlite tests on freebsd fail with ModuleNotFoundError: No module named '_sqlite3'#26873 doc: add databases/py-sqlite3 to FreeBSD test suite deps

test: skip sqlite3 tests if it isn't available #26882

Reviews