This PR simplies the functional test p2p_permissions.py by using MiniWallet in order to avoid manual low-level tx creation. Also, rather than mining 100 blocks manually, the pre-mined chain of the test framework is used, which speeds up the test a little (~2-3 seconds faster on my machine).
test: refactor: simplify p2p_permissions.py by using MiniWallet #26892
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202301-test-use_MiniWallet_in_p2p_permissions changing 1 files +6 −22-
theStack commented at 12:18 AM on January 15, 2023: contributor
-
8cbd926a2c
test: refactor: simplify p2p_permissions.py by using MiniWallet
Also, use the pre-mined chain of the test framework rather than mining 100 blocks manually on each run.
-
DrahtBot commented at 12:18 AM on January 15, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK MarcoFalke If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Jan 15, 2023
-
maflcko commented at 9:36 AM on January 16, 2023: member
ACK 8cbd926a2c5f230dbb39c88eff9c5955068e7e41
- maflcko merged this on Jan 16, 2023
- maflcko closed this on Jan 16, 2023
- theStack deleted the branch on Jan 16, 2023
- sidhujag referenced this in commit 4fff1cbd2c on Jan 16, 2023
- maflcko referenced this in commit ffc22b7d42 on Jan 26, 2023
- bitcoin locked this on Jan 16, 2024
