test: refactor: simplify p2p_{tx_download,eviction}.py by using MiniWallet #26923

pull theStack wants to merge 2 commits into bitcoin:master from theStack:202301-test-simplify_p2p_tx_download_MiniWallet changing 2 files +18 −39
  1. theStack commented at 3:41 PM on January 19, 2023: contributor

    Similar to #26892, this PR simplies the functional tests p2p_tx_download.py and p2p_eviction.py by using MiniWallet in order to avoid manual low-level tx creation. For the latter, rather than mining 100 blocks manually, the pre-mined chain of the test framework is used.

    These instances were found via $ git grep signrawtransactionwithkey ./test/functional. AFAICT, there are no other instances where MiniWallet could replace tx creation trivially.

  2. test: refactor: simplify p2p_tx_download.py by using MiniWallet 7aa4b32cd4
  3. test: refactor: simplify p2p_eviction.py by using MiniWallet
    Also, use the pre-mined chain of the test framework rather than
    mining 100 blocks manually on each run.
    8609f24be2
  4. DrahtBot commented at 3:41 PM on January 19, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. DrahtBot added the label Tests on Jan 19, 2023
  6. maflcko commented at 2:53 PM on January 26, 2023: member

    review ACK 8609f24be2a761e84e052f965587540d5b3b5315

  7. maflcko merged this on Jan 26, 2023
  8. maflcko closed this on Jan 26, 2023

  9. theStack deleted the branch on Jan 26, 2023
  10. sidhujag referenced this in commit c429fd6ce8 on Jan 26, 2023
  11. bitcoin locked this on Jan 26, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me