test: Remove redundant key_to_p2pkh call #26894

pull KolbyML wants to merge 1 commits into bitcoin:master from KolbyML:test-redundant-assignment changing 1 files +1 −3

KolbyML commented at 12:58 AM on January 16, 2023: contributor

Removed unnecessary function call and assignment get_generate_key() already calls key_to_p2pkh() and stores it in the object as p2pkh_addr.

key.p2pkh_addr is already used for most testcases as well, so it is just a redundant call
DrahtBot commented at 12:58 AM on January 16, 2023: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #22838 (descriptors: Be able to specify change and receiving in a single descriptor string by achow101)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
DrahtBot added the label Tests on Jan 16, 2023
test: Remove redundant function call 61360e0cf9
KolbyML force-pushed on Jan 16, 2023

Type	Reviewers
ACK	MarcoFalke

in test/functional/wallet_importdescriptors.py:128 in 61360e0cf9

 125 |                                "internal": True},
 126 |                               success=True)
 127 | -        info = w1.getaddressinfo(addr)
 128 | +        info = w1.getaddressinfo(key.p2pkh_addr)
 129 |          assert_equal(info["ismine"], True)
 130 |          assert_equal(info["ischange"], True)

kouloumos commented at 9:20 AM on January 16, 2023:

as you are touching this; for some reason, this is the only one of the related subtests that the test_address() helper method is not used.

maflcko renamed this:
~~test: Remove redundant function call~~
test: Remove redundant key_to_p2pkh call
on Jan 16, 2023
maflcko commented at 9:23 AM on January 16, 2023: member

ACK 61360e0cf9a9be44cb744b0f9dbc661b41a7cce6
maflcko merged this on Jan 16, 2023
maflcko closed this on Jan 16, 2023
sidhujag referenced this in commit 5a78ffaee2 on Jan 16, 2023
bitcoin locked this on Jan 16, 2024

Contributors

Labels

test: Remove redundant key_to_p2pkh call #26894

Reviews

Conflicts