[23.x] Backports #26921

1. 
   fanquake commented at 3:18 PM on January 19, 2023: member

   Backports:

   • #26909
   • #26924
   • https://github.com/bitcoin/bitcoin/pull/26944
2. hash: add HashedSourceWriter

   This class is the counterpart to CHashVerifier, in that it
   writes data to an underlying source stream,
   while keeping a hash of the written data.
   
   Github-Pull: #26909
   Rebased-From: da6c7aeca38e1d0ab5839a374c26af0504d603fc

   fd94befbc6
3. addrdb: Only call Serialize() once

   The previous logic would call it once for serializing into the filestream,
   and then again for serializing into the hasher. If AddrMan was changed
   in between these calls by another thread, the resulting peers.dat would
   be corrupt with non-matching checksum and data.
   Fix this by using HashedSourceWriter, which writes the data
   to the underlying stream and keeps track of the hash in one go.
   
   Github-Pull: #26909
   Rebased-From: 5eabb61b2386d00e93e6bbb2f493a56d1b326ad9

   412cd1a34e
4. 
   DrahtBot commented at 3:18 PM on January 19, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs
   Stale ACK	MarcoFalke

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. DrahtBot added the label Backport on Jan 19, 2023
6. 
   maflcko commented at 3:25 PM on January 19, 2023: member

   ACK 412cd1a34e035c1a2f35f4b4ac14eb192835950c 👬

   <details><summary>Show signature</summary>

   Signature:

   -----BEGIN PGP SIGNED MESSAGE-----
   Hash: SHA512
   
   ACK 412cd1a34e035c1a2f35f4b4ac14eb192835950c 👬
   -----BEGIN PGP SIGNATURE-----
   
   iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
   pUiz6gwAoNzijbCNloDVVJ7Ds33zFamQZr8PrN05T+q08mATepW9Hxr3vbd8vXbD
   F6WDQFaXcnF5q/ULgDQBGFibXmxIkRiL+O/QN/4y0lDNxy/0xu/oSRyaWwhUPtHs
   FAdpqrHOlqRhwfF1CBDrd/4V8feo5NfP1ehCBx5jwbasCjZ6J/lOStIPuxq7pU5k
   xkoQZrb8OaKRQW4VsVRBJ72SQqrVC3dQu6zVGKxmFtaiOfzMUq1w95ZnWFF8bt32
   wPZpsIvJRiNP1lwKx6tzi+9FfKWDgSZxgyGFxKfajEY9lkGgo5Q65JIrmWeZi8MO
   Tzdx8x2fhcSJISqFFKL+Aoy6buGJjuuVxgMnmNUdALnNrmq9vmdJxZuOZoNTjfQB
   587z6wqz/RSrulMahOnNP09kqXoZx273zV66pUiVwMt6cltjcNJh8cpywEKAYfEr
   echfqkYbe/FvjoQm12i98vG9WqUrcYcbv9wtbPBFSGsWH61+Lf0JMXwAN/VToF3i
   oHNy55Vn
   =E5XQ
   -----END PGP SIGNATURE-----
   

   </details>

7. Add missing includes to fix gcc-13 compile error

   Github-Pull: #26924
   Rebased-From: fadeb6b103cb441e0e91ef506ef29febabb10715

   398768769f
8. 23.x Add missing includes to fix gcc-13 compile error

   Additional include fixes are required to make the 23.x branch compile
   using GCC 13.

   af86266165
9. 
   fanquake commented at 12:03 PM on January 20, 2023: member

   Compiling 23.x (398768769f85cc1b6ff212ed931646b59fa1acd6) with GCC 13 requires additional include fixes to what is already backported, so I've added a commit with them.

10. fanquake referenced this in commit ea584a617c on Jan 20, 2023
11. depends: fix systemtap download URL

    Github-Pull: #26944
    Rebased-From: d81ca6619a5d05472af7f59e36cd100dd04a3a01

    52376d9217
12. 
    instagibbs commented at 3:23 PM on February 16, 2023: member

    Only extra commit/change is af862661654966d5de614755ab9bd1b5913e0959

    ACK https://github.com/bitcoin/bitcoin/pull/26921/commits/52376d9217060ce84e992e374d5dc2beae40bb06

13. DrahtBot requested review from maflcko on Feb 16, 2023
14. 
    fanquake commented at 3:56 PM on February 16, 2023: member

    Also merging this to unbreak the GCC 13 build.

15. fanquake merged this on Feb 16, 2023
16. fanquake closed this on Feb 16, 2023

    ---

17. fanquake deleted the branch on Feb 16, 2023
18. jamesdorfman referenced this in commit b1f1b184fd on Sep 25, 2023
19. bitcoin locked this on Feb 16, 2024

Review Requested
maflcko