>> will be redirected to the host system, unless the CI system is already running in docker.
This shouldn't lead to any issues, unless someone is running the CI as root, I guess.
Still, fix it to avoid problems.
ci: Fix APPEND_APT_SOURCES_LIST trying to modify the host system #26961
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2301-ci-backdoor-🐼 changing 1 files +1 −1-
maflcko commented at 7:36 PM on January 24, 2023: member
-
ci: Fix APPEND_APT_SOURCES_LIST trying to modify the host system fa88d42123
-
DrahtBot commented at 7:36 PM on January 24, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Jan 24, 2023
-
maflcko commented at 8:05 PM on January 24, 2023: member
example failures on master with command
MAKEJOBS="-j9" FILE_ENV="./ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh" ./ci/test_run_all.sh:Ubuntu/Debian (running as root):
E: The value 'buster-backports' is invalid for APT::Default-Release as such a release is not available in the sourcesUbuntu/Debian (running not as root):
./ci/test/04_install.sh: line 96: /etc/apt/sources.list: Permission deniedCentos/etc:
./ci/test/04_install.sh: line 96: /etc/apt/sources.list: No such file or directory
- fanquake approved
-
fanquake commented at 9:57 AM on January 25, 2023: member
ACK fa88d4212300cbe3c9c535a148414239ab0f8507
- maflcko merged this on Jan 25, 2023
- maflcko closed this on Jan 25, 2023
- maflcko deleted the branch on Jan 25, 2023
- sidhujag referenced this in commit 296f55376f on Jan 25, 2023
- bitcoin locked this on Jan 25, 2024
