I noticed that release-process.md refers in most places specifically to version 0.8.0, and in one place specifically to 0.5.1. This pull request fixes that.
Make release-process.md more generic #2697
pull Michagogo wants to merge 1 commits into bitcoin:master from Michagogo:master changing 1 files +5 −5-
Michagogo commented at 8:31 PM on May 25, 2013: contributor
-
BitcoinPullTester commented at 9:26 PM on May 25, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c468c1c44b50f9a105bdf4d407a5dbf7e09bd8a7 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 11:16 AM on May 26, 2013: none
ACK
-
laanwj commented at 11:39 AM on May 26, 2013: member
The reason for being overly specific is to show the exact format in which the version has to be given. I have been known for adding v's in front where there should not be, for example. If you do this, specify exactly what format is expected.
-
Diapolo commented at 11:42 AM on May 26, 2013: none
Well you are right, perhaps @Michagogo add a line describing what (new version) needs to be via an example or such.
-
Michagogo commented at 11:45 AM on May 26, 2013: contributor
@Laanwj Ah, I see what you're saying. When I get back to my computer I'll take a look and see if I can think of a way to demonstrate... The fact that it can be more than just numbers (i.e. 0.8.2rc3, not just 0.8.2) is important to clarify, IMHO. Also, I agree with you that it can be confusing regarding where you should and shouldn't prepend a `v' -- I'm not sure why it belongs in some places and not others. If you have any suggestions in the meantime regarding how to phrase it, I'd be glad to hear them. — Sent from Mailbox for iPhone
On Sun, May 26, 2013 at 2:39 PM, Wladimir J. van der Laan notifications@github.com wrote:
The reason for being overly specific is to show the exact format in which the version has to be given. I have been known for adding v's in front where there should not be, for example. If you do this, specify exactly what format is expected.
Reply to this email directly or view it on GitHub: #2697 (comment)
-
laanwj commented at 11:50 AM on May 26, 2013: member
For me the current phrasing is fine, as it says "for example" and 0.8.0 is just an example. You could make it 0.8.0rc3 to show that the rc, if relevant, also needs to be added.
-
BitcoinPullTester commented at 2:50 PM on May 26, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/3b807eb90e357524ccc94c333afbdbc1553ef697 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
sipa commented at 4:12 AM on May 30, 2013: member
ACK
-
fanquake commented at 9:12 AM on May 30, 2013: member
@Michagogo Can you squash this into a single commit?
-
bb70bbfc5d
Made more generic by removing specific version references
Tweaked a little bit to provide examples. Squashed commits into 1, while hoping not to break anything
-
laanwj commented at 11:51 AM on May 30, 2013: member
ACK
- laanwj referenced this in commit ba35ecc003 on May 30, 2013
- laanwj merged this on May 30, 2013
- laanwj closed this on May 30, 2013
- DrahtBot locked this on Sep 8, 2021