TxToJSON() and TxToUniv() are only to be called when we want to decode the transaction (i.e. its details) into JSON. If TxVerbosity is SHOW_TXID, the function should not have been (and currently is not) called in the first place.
There is no behaviour change, current logic simply assumes anything less than TxVerbosity::SHOW_DETAILS_AND_PREVOUT equals TxVerbosity::SHOW_DETAILS. With this change, the assumptions and intent become more explicit.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | w0xlt |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.
src/rpc/rawtransaction.cpp:61: assert(verbosity >= TxVerbosity::SHOW_DETAILS);
`TxToJSON()` and `TxToUniv()` are only to be called when we want to
decode the transaction (i.e. its details) into JSON. If `TxVerbosity` is
`SHOW_TXID`, the function should not have been (and currently is not)
called in the first place.
There is no behaviour change, current logic simply assumes anything less
than `TxVerbosity::SHOW_DETAILS_AND_PREVOUT` equals
`TxVerbosity::SHOW_DETAILS`. With this change, the assumptions and
intent become more explicit.
