depends: define `__BSD_VISIBLE` for FreeBSD bdb build #26994

1. 
   fanquake commented at 1:46 PM on January 30, 2023: member

   Required for additional definitions (IPC_R & friends), to be available, when compiling under C11, which would otherwise cause compile fails.

   See: https://github.com/MarcoFalke/btc_nightly/pull/4.

2. depends: define `__BSD_VISIBLE` for FreeBSD bdb build

   Required for additional definitions (IPC_R & friends), to be available,
   when compiling under C11.
   
   See: https://github.com/MarcoFalke/btc_nightly/pull/4.

   0e02f72548
3. fanquake added the label Build system on Jan 30, 2023
4. 
   DrahtBot commented at 1:46 PM on January 30, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. maflcko removed the label Build system on Jan 30, 2023
6. DrahtBot added the label Build system on Jan 30, 2023
7. fanquake requested review from TheCharlatan on Feb 6, 2023
8. fanquake requested review from hebasto on Feb 7, 2023
9. fanquake requested review from vasild on Feb 7, 2023
10. hebasto approved
11. 
    hebasto commented at 3:18 PM on February 8, 2023: member

    ACK 0e02f725482dd30b9f03903074a481af1164411d, tested on FreeBSD 13.1:

    $ gmake -C depends bdb
    ...
    Postprocessing bdb...
    Caching bdb...
    gmake: Leaving directory '/usr/home/hebasto/bitcoin/depends'
    

12. in depends/packages/bdb.mk:18 in 0e02f72548

      14 | @@ -15,7 +15,7 @@ $(package)_config_opts_netbsd=--with-pic
      15 |  $(package)_config_opts_openbsd=--with-pic
      16 |  $(package)_config_opts_android=--with-pic
      17 |  $(package)_cflags+=-Wno-error=implicit-function-declaration -Wno-error=format-security
      18 | -$(package)_cppflags_freebsd=-D_XOPEN_SOURCE=600
      19 | +$(package)_cppflags_freebsd=-D_XOPEN_SOURCE=600 -D__BSD_VISIBLE=1
    

    ---

    ---

    

    maflcko commented at 3:25 PM on February 8, 2023:

    Maybe document that this can be removed along with the bdb removal?

    ---

    

    fanquake commented at 3:27 PM on February 8, 2023:

    I think we'll delete this file entirely if/when bdb is removed, so probably self-documenting?

    ---

    

    hebasto commented at 3:27 PM on February 8, 2023:

    Maybe document that this can be removed along with the bdb removal?

    It seems inevitable as file name is bdb.mk :)

13. maflcko merged this on Feb 8, 2023
14. maflcko closed this on Feb 8, 2023

    ---

15. fanquake deleted the branch on Feb 8, 2023
16. sidhujag referenced this in commit c5d0ade480 on Feb 8, 2023
17. bitcoin locked this on Feb 8, 2024

Contributors

fanquakeDrahtBothebastomaflcko

Review Requested
vasildTheCharlatan