Seems more dev friendly to also have a patch to copy-paste
ci: Print iwyu patch in git diff format #27012
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2302-ci-iwyu-git-diff-📖 changing 1 files +6 −1-
maflcko commented at 11:48 AM on February 1, 2023: member
-
DrahtBot commented at 11:48 AM on February 1, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto, fanquake, stickies-v If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #26763 (ci: Treat IWYU violations as errors by hebasto)
- #25797 (build: Add CMake-based build system by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- DrahtBot added the label Tests on Feb 1, 2023
-
stickies-v commented at 12:54 PM on February 1, 2023: contributor
Concept ACK
-
hebasto commented at 1:09 PM on February 1, 2023: member
Concept ACK. Thank you for picking it up!
It is possible to leverage the fix_includes.py tool
Could probably make sense to add this to the CI, to allow easy copy-pasting from Cirrus or from a local run.
-
ci: Print iwyu patch in git diff format fa6986a66b
- maflcko force-pushed on Feb 1, 2023
-
hebasto commented at 1:24 PM on February 1, 2023: member
a patch to copy-paste
To be pedantic, a manual replacement quotes
"..."with angle brackets<...>is still required for non-system headers, unfortunately. - hebasto approved
-
hebasto commented at 1:32 PM on February 1, 2023: member
ACK fa6986a66b451f532a1aa2bd72c956fcd8c0d042, tested on Ubuntu 22.04 locally.
-
maflcko commented at 2:35 PM on February 1, 2023: member
Example output: https://cirrus-ci.com/task/5039323280572416?logs=ci#L5652
- fanquake approved
-
fanquake commented at 3:14 PM on February 2, 2023: member
ACK fa6986a66b451f532a1aa2bd72c956fcd8c0d042 - did not test but example CI output looks ok.
- stickies-v approved
-
stickies-v commented at 3:45 PM on February 2, 2023: contributor
utACK fa6986a66b451f532a1aa2bd72c956fcd8c0d042
- fanquake merged this on Feb 2, 2023
- fanquake closed this on Feb 2, 2023
- maflcko deleted the branch on Feb 3, 2023
- sidhujag referenced this in commit a2a2f918a7 on Feb 3, 2023
- bitcoin locked this on Feb 3, 2024
