mapport: require miniupnpc API version 17 or later #27016

1. 
   fanquake commented at 4:06 pm on February 1, 2023: member

   Version 17 is currently the latest version, see: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt, and has been available since the release of 2.1. 2.1 or newer is readily available across all distros, see https://repology.org/project/miniupnpc/versions, so drop support for the older API versions.

   Split out of #22644.

2. mapport: require miniupnpc API version 17 or later

   Version 17 is currently the latest version, and has been available since
   the release of 2.1.
   See: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt.

   b3b673f704
3. 
   DrahtBot commented at 4:06 pm on February 1, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto, TheCharlatan
   Concept ACK	dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #22644 (Deprecate UPnP support, require 2.1 or later by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   dergoegge commented at 4:14 pm on February 1, 2023: member

   Concept ACK
5. 
   hebasto commented at 10:56 am on February 3, 2023: member

   Concept ACK.
6. 
   hebasto commented at 11:11 am on February 3, 2023: member

   Now we can use PKG_CHECK_MODULES instead of https://github.com/bitcoin/bitcoin/blob/7753efcbcf3ca2e1b46f167936e11cc580e28c7a/configure.ac#L1414-L1418 as pkgconfig/miniupnpc.pc is being provided with a newer libminiupnpc-dev package across of all major distros and macOS’s Homebrew.
7. 
   fanquake commented at 11:14 am on February 3, 2023: member

   Now we can use PKG_CHECK_MODULES instead of

   That doesn’t quite work. But is already part of #22644 in any case.

8. 
   hebasto commented at 11:25 am on February 3, 2023: member

   Now we can use PKG_CHECK_MODULES instead of

   That doesn’t quite work.

   I’m not sure what it means, but my point is that using PKG_CHECK_MODULES makes the MINIUPNPC_API_VERSION check redundant.

9. 
   fanquake commented at 12:04 pm on February 3, 2023: member

   I’m not sure what it means,

   You can’t use it, because it’s not supported for mingw-w64 builds using 2.1. So while we could patch depends, distro/self-builds would be broken.

10. hebasto approved
11. 
    hebasto commented at 1:14 pm on February 3, 2023: member

    ACK b3b673f7048cce1d1368819abb0b58b7c6699fa5, tested on Ubuntu 20.04 w/ and w/o libminiupnpc-dev package.
12. fanquake requested review from TheCharlatan on Feb 13, 2023
13. TheCharlatan approved
14. 
    TheCharlatan commented at 3:34 pm on February 13, 2023: contributor

    ACK b3b673f7048cce1d1368819abb0b58b7c6699fa5

    Tested against miniupnpc version 2.0 (API version 16) and it failed as expected. Also tested against system libminiupnpc-dev on Ubuntu 22.04.

15. fanquake merged this on Feb 13, 2023
16. fanquake closed this on Feb 13, 2023

    ---

17. fanquake deleted the branch on Feb 13, 2023
18. sidhujag referenced this in commit 5182c4efae on Feb 14, 2023
19. bitcoin locked this on Feb 13, 2024

Contributors
fanquake DrahtBot dergoegge hebasto TheCharlatan