doc: use arch agnostic clang path in fuzzing doc (macOS) #27056

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:macos_fuzzing_doc_arch_agnostic changing 1 files +2 −2

fanquake commented at 4:56 PM on February 7, 2023: member

The current path will only work for clang installed via brew on x86_64 macOS.
DrahtBot commented at 4:56 PM on February 7, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto

Stale ACK jonatack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Docs on Feb 7, 2023

Type	Reviewers
ACK	hebasto
Stale ACK	jonatack

in doc/fuzzing.md:142 in 8b16f7b7c2 outdated

 138 | @@ -139,7 +139,7 @@ You may also need to take care of giving the correct path for `clang` and
 139 |  Full configure that was tested on macOS Catalina with `brew` installed `llvm`:
 140 |  
 141 |  ```sh
 142 | -./configure --enable-fuzz --with-sanitizers=fuzzer,address,undefined CC=/usr/local/opt/llvm/bin/clang CXX=/usr/local/opt/llvm/bin/clang++ --disable-asm
 143 | +./configure --enable-fuzz --with-sanitizers=fuzzer,address,undefined --disable-asm CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++

jonatack commented at 5:29 PM on February 7, 2023:

Tested with brew-installed llvm 15.0.7, is there a workaround or open pull for the boost issues?

In file included from wallet/test/fuzz/notifications.cpp:11:
In file included from ./wallet/receive.h:11:
In file included from ./wallet/wallet.h:27:
./wallet/scriptpubkeyman.h:21:10: fatal error: 'boost/signals2/signal.hpp' file not found
#include <boost/signals2/signal.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

In file included from test/fuzz/block.cpp:14:
In file included from ./validation.h:29:
./txmempool.h:35:10: fatal error: 'boost/multi_index/hashed_index.hpp' file not found
#include <boost/multi_index/hashed_index.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

fanquake commented at 5:36 PM on February 7, 2023:

#27057. I don't think that's a blocker for fixing the docs.

jonatack commented at 5:39 PM on February 7, 2023:

Nice.

jonatack commented at 5:34 PM on February 7, 2023: contributor

Concept ACK, as it looks like the path changed from /usr/local/opt/ for x86_64 to /opt/homebrew/opt/ for ARM64.
jonatack commented at 5:49 PM on February 7, 2023: contributor

ACK 8b16f7b7c2fa7407ec4023f4581ea9dd1758eec0
doc: use arch agnostic clang path in fuzzing doc (macOS) b49e19ccd9

in doc/fuzzing.md:139 in 8b16f7b7c2 outdated

 138 | @@ -139,7 +139,7 @@ You may also need to take care of giving the correct path for `clang` and
 139 |  Full configure that was tested on macOS Catalina with `brew` installed `llvm`:

jonatack commented at 6:51 PM on February 7, 2023:

Full configure that was tested on macOS with `brew` installed `llvm`:

fanquake commented at 9:45 AM on February 8, 2023:

Dropped.

fanquake force-pushed on Feb 8, 2023
hebasto approved
hebasto commented at 11:47 AM on February 8, 2023: member
ACK b49e19ccd9a50053c69cd42bae1b44df07890cfd, similar to 702836530ffa351e863b1b1300fd2e559a14ef23.

I've also verified our code base for other similar cases:
```
$ git grep -e "/usr/local/opt" | wc -l
0
```
maflcko merged this on Feb 8, 2023
maflcko closed this on Feb 8, 2023
fanquake deleted the branch on Feb 8, 2023
sidhujag referenced this in commit 9ab60528db on Feb 8, 2023
bitcoin locked this on Feb 8, 2024

Contributors

Labels

doc: use arch agnostic clang path in fuzzing doc (macOS) #27056

Reviews