Blockstorage: Dont access gArgs to get blocks_dir #27103

pull TheCharlatan wants to merge 1 commits into bitcoin:master from TheCharlatan:blockstorageArgs changing 26 files +123 −109
  1. TheCharlatan commented at 11:03 AM on February 15, 2023: contributor

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Blockstorage: Dont access gArgs to get blocks_dir 45c0f72ab1
  3. DrahtBot commented at 11:03 AM on February 15, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Block storage on Feb 15, 2023
  5. TheCharlatan closed this on Feb 15, 2023

  6. bitcoin locked this on Feb 19, 2023
  7. bitcoin unlocked this on Mar 9, 2023
  8. ryanofsky commented at 4:44 PM on March 9, 2023: contributor

    @TheCharlatan

    Curious why this PR was closed, and what is its relationship to #27125? Is that a PR a replacement or superset or a different approach?

  9. TheCharlatan commented at 4:53 PM on March 9, 2023: contributor

    Curious why this PR was closed, and what is its relationship to #27125? Is that a PR a replacement or superset or a different approach?

    I hit the wrong button by mistake :) - I should have left a comment, or better re-opened as a draft. The approach started here is the same though as in #27125.

  10. bitcoin locked this on Mar 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me