Permission to comment on closed PRs #27234

issue ryanofsky opened this issue on March 9, 2023

ryanofsky commented at 3:07 PM on March 9, 2023: contributor

I noticed recently I couldn't comment on two closed PRs. One is #27103 which was closed without an explanation. I wanted to ask why it was closed and whether #27125 might be a replacement for it. The other was my own PR #18608, which I wanted to reopen, but couldn't (even though the branch commit was unchanged at the time), so I opened another PR #27224, and now I can't comment on #18608 to say that it's been replaced by #27224.

I'm guessing the restrictions on comments are an anti-spam measure, so I wonder if there is a technical fix that would allow ordinary project members to comment on closed PRs like these?

FWIW the messages I see on these two PRs are "fanquake locked and limited conversation to collaborators 3 weeks ago" and "DrahtBot locked as resolved and limited conversation to collaborators on Aug 16, 2022"
ryanofsky added the label Bug on Mar 9, 2023
fanquake removed the label Bug on Mar 9, 2023
fanquake commented at 3:14 PM on March 9, 2023: member

Yea. Threads are locked to combat spam (and/or when it's clear that the PRs are accidental, wrong repo etc). I've unlocked both now, if you'd like to comment. We can look at if there is some permissions change we can make.
maflcko commented at 3:15 PM on March 9, 2023: member

I think you can just leave a comment on the open pull to refer to the closed one. Generally, after a long time (1 year) of being closed the discussion is locked to avoid notification of people who left the project or otherwise open the door widely for drive-by spammers.

If you really need or want to comment on a locked pull, my recommendation would be to unlock it first. Otherwise there is no way for someone else to reply.
achow101 commented at 4:18 PM on March 9, 2023: member

We can look at if there is some permissions change we can make.

IIRC it requires the "write" permission, which only maintainers have as it allows adding new commits to the repo.
ryanofsky commented at 4:52 PM on March 9, 2023: contributor

Thanks for unlocking the PRs.

That is a good point that ability to comment on a locked PR is not really useful because relevant people won't be able to respond. Maybe ideally there would be a way to request that DrahtBot unlocks the PR, and then subsequently relocks it after a period of idle time (like a week or month).

Meantime, I guess I can use this issue to request things to be unlocked if the need arises. (At least until this issue itself is locked :grin:)
ryanofsky closed this on Mar 9, 2023
ryanofsky commented at 2:52 PM on April 7, 2023: contributor

Could a maintainers unlock an old PR of mine #21353? I wanted to add a note on #21353 f5ba424c line 3774 that there was an unintented change of behavior in that commit.
fanquake commented at 2:53 PM on April 7, 2023: member

Could a maintainers unlock an old PR of mine #21353?

Done.
bitcoin locked this on Apr 6, 2024

Contributors

Linked (view graph)

#18608 refactor: Remove CAddressBookData::destdata #27103 Blockstorage: Dont access gArgs to get blocks_dir #27125 refactor, kernel: Decouple ArgsManager from blockstorage #27224 refactor: Remove CAddressBookData::destdata