CSubNet::SanityCheck() was added in #20140, and not removed in #22570 when it became orphaned code.
Also, remove an out-of-date snprintf TODO that was resolved in #27036, and fix up 2 words to make the spelling linter green again.
net: remove orphaned CSubNet::SanityCheck() #27106
pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:2023-02-rm-CSubNet-SanityCheck-and-snprintf-todo changing 5 files +2 −29-
jonatack commented at 10:46 PM on February 15, 2023: contributor
-
0e015146bd
net: remove orphaned CSubNet::SanityCheck()
CSubNet::SanityCheck() was added in #20140, and not removed in #22570 when it became orphaned code.
-
30a3230e86
script: remove out-of-date snprintf TODO
that was resolved in PR27036 "test: Remove last uses of snprintf and simplify" and while here, fix up 2 words in docs to make the spelling linter green again.
-
DrahtBot commented at 10:46 PM on February 15, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label P2P on Feb 15, 2023
- fanquake approved
-
fanquake commented at 9:48 AM on February 16, 2023: member
ACK 30a3230e86dfd49c771432be6219841df5066eb4
- pinheadmz approved
- pinheadmz approved
-
pinheadmz commented at 6:27 PM on February 16, 2023: member
ACK 30a3230e86dfd49c771432be6219841df5066eb4
<details><summary>Show Signature</summary>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 ACK 30a3230e86dfd49c771432be6219841df5066eb4 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmPudFYACgkQ5+KYS2KJ yTrYnA/+LcTOT8/zvgcEeQ/nMhbO3LijgTmdio0OZS/dMc6SKdeAT/mDXv0ThjhB +K7FuHY9fYO9sbXqPNkrbEfGR3iwqCNu5ElEAmvOMqVZIfkLHy//AX/uKNlUx2h7 1bICzt3PnnhaeGUWWxUeU+HFSpLikl6OHUYZLJfT+2VTz8rdMxhSY5iKSUEZNDKZ J3D3B5nM8NtpkcMsuXJHEPsAqLvrYtt23Tw0dgTKGzfwr6Ai/WdcSSQn0jfHBIYc mnj8dVG+hYLdTiVyXQ/bikf4M6kwPMn4H1QnHgHCFVEdlZyPvJ0wvPqTlLTFp009 8ZuGqm8VIfLntRNIhWe9FA7BZ6rz11uWfJgp+dmq9UGz0ohwZ0zI7NH9dhLYuRXN NUdwLf8qBmdwsB7U9EVucApMFcCD7UGhn9cotQxPcJo/yTvMzL1GF/jLARxMLeod dKGZBj4ymo6jxQZyGIgKs6LIS9IKjhm54qh2hXpm/4S2G4IktBvPts6HlDKPHdmB PA+BEgDgnilHaxz/jnl3U2uK+D6v9ilv+LDtG0scBfdwx2zpn/VfdNtVbBtOTpWX ILaA8JmaMcRytezYCDfFF+8KJLtX5JfIPWc9Po1tuRnpc4yKpf6xqeFlcvfLU67a 6J+VtZ2cznz3JRiEocvo6tbeoI0r+j4XYs711430al4pAQLDUQc= =iM7z -----END PGP SIGNATURE-----pinheadmz's public key is on keybase
</details>
- pinheadmz approved
-
pinheadmz commented at 6:28 PM on February 16, 2023: member
ACK 30a3230e86dfd49c771432be6219841df5066eb4
<details><summary>Show Signature</summary>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 ACK 30a3230e86dfd49c771432be6219841df5066eb4 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmPudFYACgkQ5+KYS2KJ yTrYnA/+LcTOT8/zvgcEeQ/nMhbO3LijgTmdio0OZS/dMc6SKdeAT/mDXv0ThjhB +K7FuHY9fYO9sbXqPNkrbEfGR3iwqCNu5ElEAmvOMqVZIfkLHy//AX/uKNlUx2h7 1bICzt3PnnhaeGUWWxUeU+HFSpLikl6OHUYZLJfT+2VTz8rdMxhSY5iKSUEZNDKZ J3D3B5nM8NtpkcMsuXJHEPsAqLvrYtt23Tw0dgTKGzfwr6Ai/WdcSSQn0jfHBIYc mnj8dVG+hYLdTiVyXQ/bikf4M6kwPMn4H1QnHgHCFVEdlZyPvJ0wvPqTlLTFp009 8ZuGqm8VIfLntRNIhWe9FA7BZ6rz11uWfJgp+dmq9UGz0ohwZ0zI7NH9dhLYuRXN NUdwLf8qBmdwsB7U9EVucApMFcCD7UGhn9cotQxPcJo/yTvMzL1GF/jLARxMLeod dKGZBj4ymo6jxQZyGIgKs6LIS9IKjhm54qh2hXpm/4S2G4IktBvPts6HlDKPHdmB PA+BEgDgnilHaxz/jnl3U2uK+D6v9ilv+LDtG0scBfdwx2zpn/VfdNtVbBtOTpWX ILaA8JmaMcRytezYCDfFF+8KJLtX5JfIPWc9Po1tuRnpc4yKpf6xqeFlcvfLU67a 6J+VtZ2cznz3JRiEocvo6tbeoI0r+j4XYs711430al4pAQLDUQc= =iM7z -----END PGP SIGNATURE-----pinheadmz's public key is on keybase
</details>
- brunoerg approved
-
brunoerg commented at 9:28 PM on February 16, 2023: contributor
crACK 30a3230e86dfd49c771432be6219841df5066eb4
- fanquake merged this on Feb 17, 2023
- fanquake closed this on Feb 17, 2023
- jonatack deleted the branch on Feb 17, 2023
- sidhujag referenced this in commit ef111be3dd on Feb 17, 2023
- bitcoin locked this on Feb 17, 2024
