doc: recommend brew install python@3.7 (minimum version) #27130

pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:1676913327/0fe225e37/9c47eb450-build-osx-python3.7-minimum changing 1 files +2 −2
  1. RandyMcMillan commented at 5:34 pm on February 20, 2023: contributor
  2. DrahtBot commented at 5:34 pm on February 20, 2023: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK brunoerg, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. fanquake commented at 5:35 pm on February 20, 2023: member
    NACK. There’s no need to install an old version of Python.
  4. fanquake renamed this:
    build-osx.md: recommend brew install python@3.7 (minimum version)
    doc: recommend brew install python@3.7 (minimum version)
    on Feb 20, 2023
  5. DrahtBot added the label Docs on Feb 20, 2023
  6. brunoerg commented at 5:38 pm on February 20, 2023: member

    NACK

    For me it doesn’t make sense to suggest to install the minimum version. I prefer to have users with the most recent one, not the minimum one.

  7. doc/build-osx.md: brew install python@3 b2f2951e51
  8. RandyMcMillan force-pushed on Feb 20, 2023
  9. fanquake commented at 5:44 pm on February 20, 2023: member
    NACK - python and python@3 are the same thing (both aliases for python 3.11, which is the current latest version). We can leave these docs as-is, and/or worry about changing them when Python 4 is (never) released. Thanks.
  10. fanquake closed this on Feb 20, 2023

  11. RandyMcMillan commented at 6:12 pm on February 20, 2023: contributor

    To maintain consistency across macOS x86 and Arm64 maybe the minimum python3 version should be python@3.8

    Screen Shot 2023-02-20 at 1 00 41 PM

    ref: #26226

  12. Sjors commented at 9:49 am on February 21, 2023: member
    @RandyMcMillan maybe make a separate issue about M1 not supporting Python 3.7 (I don’t have one, so can’t confirm). It’s just one of many operating systems we support, but a lot of devs use it so it seems worth looking into.
  13. fanquake commented at 9:57 am on February 21, 2023: member
    Thanks, but there is no need to make an issue. There is nothing here that needs to be solved.
  14. fanquake locked this on Feb 25, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me