No description provided.
doc: recommend brew install python@3.7 (minimum version) #27130
pull RandyMcMillan wants to merge 1 commits into bitcoin:master from RandyMcMillan:1676913327/0fe225e37/9c47eb450-build-osx-python3.7-minimum changing 1 files +2 −2-
RandyMcMillan commented at 5:34 PM on February 20, 2023: contributor
-
DrahtBot commented at 5:34 PM on February 20, 2023: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
fanquake commented at 5:35 PM on February 20, 2023: member
NACK. There's no need to install an old version of Python.
- fanquake renamed this:
build-osx.md: recommend brew install python@3.7 (minimum version)
doc: recommend brew install python@3.7 (minimum version)
on Feb 20, 2023 - DrahtBot added the label Docs on Feb 20, 2023
-
brunoerg commented at 5:38 PM on February 20, 2023: member
NACK
For me it doesn't make sense to suggest to install the minimum version. I prefer to have users with the most recent one, not the minimum one.
-
doc/build-osx.md: brew install python@3 b2f2951e51
- RandyMcMillan force-pushed on Feb 20, 2023
-
RandyMcMillan commented at 5:44 PM on February 20, 2023: contributor
updated :
brew install python@3 -
fanquake commented at 5:44 PM on February 20, 2023: member
NACK -
pythonandpython@3are the same thing (both aliases for python 3.11, which is the current latest version). We can leave these docs as-is, and/or worry about changing them when Python 4 is (never) released. Thanks. - fanquake closed this on Feb 20, 2023
-
RandyMcMillan commented at 6:12 PM on February 20, 2023: contributor
To maintain consistency across macOS x86 and Arm64 maybe the minimum python3 version should be python@3.8
ref: #26226
-
Sjors commented at 9:49 AM on February 21, 2023: member
@RandyMcMillan maybe make a separate issue about M1 not supporting Python 3.7 (I don't have one, so can't confirm). It's just one of many operating systems we support, but a lot of devs use it so it seems worth looking into.
-
fanquake commented at 9:57 AM on February 21, 2023: member
Thanks, but there is no need to make an issue. There is nothing here that needs to be solved.
- fanquake locked this on Feb 25, 2023
