test: Raise PRNG seed log to INFO #27137

pull roconnor-blockstream wants to merge 1 commits into bitcoin:master from roconnor-blockstream:patch-1 changing 1 files +2 −2
  1. roconnor-blockstream commented at 5:01 PM on February 21, 2023: contributor

    Some build infrastructure, such as Nix, will delete failed builds by default, keeping only the log (stdout/stderr) of the failed build.

    For flaky tests, it would be very helpful to have the PRNG seed in the default log in order to redo the failed test.

    By simply raising the PRNG seed logging to INFO, we can, by default, record the seed in the log of every build.

  2. Raise PRNG seed log to INFO.
    Some build infrastructure, such as Nix, will delete failed builds by default, keeping only the log of the failed build.
    
    For flaky tests, it would be very helpful to have the PRNG seed in the default log in order to redo the failed test.
    
    By simply raising the PRNG seed logging to INFO, we can, by default, record the seed in the log of every build.
    4d84eaec82
  3. DrahtBot commented at 5:01 PM on February 21, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke, theStack
    Concept ACK prusnak, erikarvstedt

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko renamed this:
    Raise PRNG seed log to INFO.
    test: Raise PRNG seed log to INFO
    on Feb 21, 2023
  5. DrahtBot added the label Tests on Feb 21, 2023
  6. fanquake commented at 9:52 AM on February 22, 2023: member
  7. prusnak approved
  8. prusnak commented at 9:54 AM on February 22, 2023: contributor

    Concept ACK

  9. maflcko commented at 9:55 AM on February 22, 2023: member

    lgtm ACK 4d84eaec82e7b5a450d47cd30e5936a717035f77

  10. erikarvstedt approved
  11. erikarvstedt commented at 9:59 AM on February 22, 2023: contributor

    Concept ACK

  12. theStack approved
  13. theStack commented at 1:58 PM on February 22, 2023: contributor

    ACK 4d84eaec82e7b5a450d47cd30e5936a717035f77

  14. fanquake merged this on Feb 22, 2023
  15. fanquake closed this on Feb 22, 2023

  16. roconnor-blockstream deleted the branch on Feb 22, 2023
  17. sidhujag referenced this in commit 0a9c800266 on Feb 25, 2023
  18. bitcoin locked this on Feb 22, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me