doc: update broken str util reference links on developer-notes #27220

pull pablomartin4btc wants to merge 1 commits into bitcoin:master from pablomartin4btc:patch-1 changing 1 files +2 −2
  1. pablomartin4btc commented at 2:49 PM on March 7, 2023: member

    References to utilstrencodings and lint-locale-dependence.sh where incorrect, updating them accordingly.

    Also, adding another reference to util function LocaleIndependentAtoi, which is related with the updated section of the guide:

    // LocaleIndependentAtoi is provided for backwards compatibility reasons.
    //
    // New code should use ToIntegral or the ParseInt* functions
    // which provide parse error feedback.
    //
    // The goal of LocaleIndependentAtoi is to replicate the defined behaviour of
    // std::atoi as it behaves under the "C" locale, and remove some undefined
    // behavior. If the parsed value is bigger than the integer type's maximum
    // value, or smaller than the integer type's minimum value, std::atoi has
    // undefined behavior, while this function returns the maximum or minimum
    // values, respectively.
    
  2. DrahtBot commented at 2:50 PM on March 7, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Docs on Mar 7, 2023
  4. pablomartin4btc renamed this:
    doc: update broken links on developer-notes
    doc: update broken str util reference links on developer-notes
    on Mar 7, 2023
  5. pablomartin4btc force-pushed on Mar 7, 2023
  6. in doc/developer-notes.md:860 in e422b5648e outdated
     856 | @@ -857,12 +857,12 @@ Strings and formatting
     857 |      buffer overflows, and surprises with `\0` characters. Also, some C string manipulations
     858 |      tend to act differently depending on platform, or even the user locale.
     859 |  
     860 | -- Use `ParseInt32`, `ParseInt64`, `ParseUInt32`, `ParseUInt64`, `ParseDouble` from `utilstrencodings.h` for number parsing.
     861 | +- Use `ToIntegral` or `ParseInt32`, `ParseInt64`, `ParseUInt32`, `ParseUInt64`, `ParseDouble` from [`strencodings.h`](/src/util/strencodings.h) for number parsing. Or use `LocaleIndependentAtoi` which replicates `std::atoi` for backwards compatibility reasons.
    


    fanquake commented at 7:59 AM on March 8, 2023:

    You could put this on a new line, rather than making this one ridiculously long.


    maflcko commented at 8:09 AM on March 8, 2023:

    ParseInt* is for legacy code only, as well


    pablomartin4btc commented at 9:07 PM on March 8, 2023:

    ok


    pablomartin4btc commented at 9:08 PM on March 8, 2023:

    updated it.

  7. pablomartin4btc closed this on Mar 8, 2023

  8. pablomartin4btc deleted the branch on Mar 8, 2023
  9. pablomartin4btc restored the branch on Mar 8, 2023
  10. pablomartin4btc reopened this on Mar 8, 2023

  11. pablomartin4btc closed this on Mar 8, 2023

  12. pablomartin4btc deleted the branch on Mar 8, 2023
  13. pablomartin4btc restored the branch on Mar 8, 2023
  14. pablomartin4btc reopened this on Mar 8, 2023

  15. pablomartin4btc force-pushed on Mar 8, 2023
  16. pablomartin4btc force-pushed on Mar 8, 2023
  17. doc: update broken links da347de530
  18. pablomartin4btc force-pushed on Mar 8, 2023
  19. maflcko commented at 10:05 AM on March 9, 2023: member

    lgtm ACK da347de530242ead8f6a9718ee1440385bd3d44d

  20. fanquake merged this on Mar 11, 2023
  21. fanquake closed this on Mar 11, 2023

  22. sidhujag referenced this in commit 62d565c7d7 on Mar 12, 2023
  23. bitcoin locked this on Mar 10, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me