No description provided.
test: Fix TypeError (expected str instance, bytes found) in wait_for_debug_log #27280
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2303-test-type-error-bytes-🤓 changing 1 files +1 −1-
maflcko commented at 10:55 AM on March 20, 2023: member
-
33337eb860
test: Fix TypeError in wait_for_debug_log
Traceback: print_log = " - " + "\n - ".join(log.splitlines()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: sequence item 0: expected str instance, bytes found -
DrahtBot commented at 10:55 AM on March 20, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK davidgumberg If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Tests on Mar 20, 2023
-
maflcko commented at 10:55 AM on March 20, 2023: member
Can be tested with:
diff --git a/test/functional/feature_init.py b/test/functional/feature_init.py index 70a802dc58..1d1c6a64b6 100755 --- a/test/functional/feature_init.py +++ b/test/functional/feature_init.py @@ -52,7 +52,7 @@ class InitStressTest(BitcoinTestFramework): assert_equal(200, node.getblockcount()) lines_to_terminate_after = [ - b'Validating signatures for all blocks', + b'.Validating signatures for all blocks', b'scheduler thread start', b'Starting HTTP server', b'Loading P2P addresses', -
ismaelsadeeq commented at 10:21 AM on March 21, 2023: member
tested Ack https://github.com/bitcoin/bitcoin/pull/27280/commits/33337eb86028662e632107411efec1e63b1c01bf ,tricky one! I have manually test the code:+1:
-
davidgumberg commented at 1:13 AM on March 22, 2023: contributor
- maflcko assigned fanquake on Mar 22, 2023
- fanquake merged this on Mar 22, 2023
- fanquake closed this on Mar 22, 2023
- maflcko deleted the branch on Mar 22, 2023
- sidhujag referenced this in commit d6ec811e31 on Mar 23, 2023
- bitcoin locked this on Mar 21, 2024
Contributors
Labels