Combine into hardened-glibc.
Document why we don't use --disable-werror directly.
https://www.gnu.org/software/libc/manual/html_node/Configuring-and-compiling.html
By default, the GNU C Library is built with -Werror. If you wish to build without this option (for example, if building with a newer version of GCC than this version of the GNU C Library was tested with, so new warnings cause the build with -Werror to fail), you can configure with --disable-werror.
Combine into hardened-glibc.
Document why we don't use --disable-werror directly.
https://www.gnu.org/software/libc/manual/html_node/Configuring-and-compiling.html
> By default, the GNU C Library is built with -Werror. If you wish
> to build without this option (for example, if building with a
> newer version of GCC than this version of the GNU C Library was
> tested with, so new warnings cause the build with -Werror to fail),
> you can configure with --disable-werror.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto, TheCharlatan |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Document why we don't use
--disable-werrordirectly.
Concept ACK on that.
Combine into
hardened-glibc.
Not against it, just clarifying. What are benefits of doing that?
I don't see a reason to keep them separated, need multiple funcs etc. I doubt we'll ever turn -Werror back on here, so hardened-glibc is really just how we build glibc.
I don't see a reason to keep them separated, need multiple funcs etc.
In the future, if we will have multiple glibc versions again, as it was when you introduced those "multiple funcs", they will be useful again.
I mean, while this change improves code readability, it hurts maintainability a bit, doesn't it?
as it was when you introduced those "multiple funcs", they will be useful again.
It was needed when we were building 2 different glibcs, in two different ways. Now we're building a single glibc, in one way, hence consolidating. We can speculate about what might happen in future, but I can't see a reason (looking at current releases), to return to multiple builds. The only reason it was done this way initially, was for RISC-V support. I also don't know why we'd turn -Werror back on again, it's not useful here.
it hurts maintainability a bit, doesn't it?
How?
ACK 4becee396f3bda40832138dd1aaa90368ed31857, the diff is correct.
ACK 4becee396f3bda40832138dd1aaa90368ed31857