fuzz: Remove legacy int parse fuzz tests #27344

1. 
   maflcko commented at 2:06 pm on March 27, 2023: member

   The fuzz tests checked that the result of the new function was equal to the legacy function. (Side note: The checks were incomplete, as evident by the follow-up fix in commit b5c9bb5cb9f4a8db57b33ef7399310c7d6de5822).

   Given that they haven’t found any issues in years (beside missing the above issue, that they couldn’t catch), it seems time to remove them.

   They may come in handy in the rare case that someone would want to modify LocaleIndependentAtoi() or Parse*Int*(), however that seems unlikely. Also, appropriate checks can be added then.

2. 
   DrahtBot commented at 2:06 pm on March 27, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fanquake, dergoegge

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Tests on Mar 27, 2023
4. fanquake requested review from dergoegge on Mar 27, 2023
5. maflcko force-pushed on Mar 27, 2023
6. fuzz: Remove legacy int parse fuzz tests faf8dc496e
7. maflcko force-pushed on Mar 27, 2023
8. 
   fanquake commented at 4:47 pm on March 27, 2023: member

   Concept ACK
9. fanquake approved
10. 
    fanquake commented at 9:56 am on March 28, 2023: member

    ACK faf8dc496e761a15956f8226d727f4bbab8dff82
11. dergoegge approved
12. 
    dergoegge commented at 10:03 am on March 28, 2023: member

    ACK faf8dc496e761a15956f8226d727f4bbab8dff82
13. fanquake merged this on Mar 28, 2023
14. fanquake closed this on Mar 28, 2023

    ---

15. maflcko deleted the branch on Mar 28, 2023
16. sidhujag referenced this in commit 44d9568eaa on Mar 28, 2023
17. bitcoin deleted a comment on Mar 30, 2023
18. bitcoin locked this on Mar 29, 2024

Contributors
maflcko DrahtBot fanquake dergoegge

Labels
Tests