This should avoid errors when running it twice. For example, network errors on the second invocation of 'apt update'; or unguarded modifications such as APPEND_APT_SOURCES_LIST, which will append the same string repeatedly.
The base install may be run twice in Cirrus CI with dockerfiles, or locally when running twice with DANGER_RUN_CI_ON_HOST specified.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | josibake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
73 | +CI_EXEC rsync --archive --stats --human-readable /ci_base_install/ "${BASE_ROOT_DIR}" || echo "CI base install missing" 74 | +CI_EXEC "${BASE_ROOT_DIR}/ci/test/01_base_install.sh" 75 | +CI_EXEC rsync --archive --stats --human-readable /ro_base/ "${BASE_ROOT_DIR}" || echo "Nothing to copy from ro_base" 76 | +# Fixes permission issues when there is a container UID/GID mismatch with the owner 77 | +# of the git source code directory. 78 | +CI_EXEC git config --global --add safe.directory '*'
I think double quotes is the safest, although I can't remember where I saw that..
For testing:
# (Obviously only run this in a throw-away VM) # DANGER_RUN_CI_ON_HOST="1" MAKEJOBS="-j1" FILE_ENV="./ci/test/00_setup_env_native_nowallet_libbitcoinkernel.sh" ./ci/test_run_all.sh
Before:
Running on host system without docker wrapper
Hit:1 http://deb.debian.org/debian buster InRelease
Hit:2 http://deb.debian.org/debian-security buster/updates InRelease
Get:3 http://deb.debian.org/debian buster-updates InRelease [56.6 kB]
Get:4 http://deb.debian.org/debian buster-backports InRelease [51.4 kB]
Fetched 108 kB in 1s (122 kB/s)
Reading package lists... Done
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:8
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:8
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:9
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:9
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:8
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:8
W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:9
W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list:7 and /etc/apt/sources.list:9
Reading package lists... Done
Building dependency tree
Reading state information... Done
Skipping automake, it is already installed and upgrade is not set.
Skipping autotools-dev, it is already installed and upgrade is not set.
Skipping bison, it is already installed and upgrade is not set.
Skipping bsdmainutils, it is already installed and upgrade is not set.
Skipping build-essential, it is already installed and upgrade is not set.
Skipping ca-certificates, it is already installed and upgrade is not set.
Skipping ccache, it is already installed and upgrade is not set.
Skipping libtool, it is already installed and upgrade is not set.
Skipping pkg-config, it is already installed and upgrade is not set.
Skipping procps, it is already installed and upgrade is not set.
Skipping python3, it is already installed and upgrade is not set.
Skipping python3-zmq, it is already installed and upgrade is not set.
Skipping curl, it is already installed and upgrade is not set.
Skipping git, it is already installed and upgrade is not set.
Skipping clang-8, it is already installed and upgrade is not set.
Skipping libc++-8-dev, it is already installed and upgrade is not set.
Skipping libc++abi-8-dev, it is already installed and upgrade is not set.
Skipping llvm-8, it is already installed and upgrade is not set.
Skipping rsync, it is already installed and upgrade is not set.
0 upgraded, 0 newly installed, 0 to remove and 20 not upgraded.
...
After:
Skip base install
...
This should avoid errors when running it twice. For example, network
errors on the second invocation of 'apt update'; or unguarded
modifications such as APPEND_APT_SOURCES_LIST, which will append the
same string repeatedly.
The base install may be run twice in Cirrus CI with dockerfiles, or
locally when running twice with DANGER_RUN_CI_ON_HOST specified.
73 | +CI_EXEC rsync --archive --stats --human-readable /ci_base_install/ "${BASE_ROOT_DIR}" || echo "/ci_base_install/ missing" 74 | +CI_EXEC "${BASE_ROOT_DIR}/ci/test/01_base_install.sh" 75 | +CI_EXEC rsync --archive --stats --human-readable /ro_base/ "${BASE_ROOT_DIR}" || echo "Nothing to copy from ro_base" 76 | +# Fixes permission issues when there is a container UID/GID mismatch with the owner 77 | +# of the git source code directory. 78 | +CI_EXEC git config --global --add safe.directory \"*\"
if you run this without docker, won't this change the user's local git config? probably fine since you should be running with docker if running locally, but might be worth mentioning in the comment
Yes, DANGER_RUN_CI_ON_HOST is called that way to discourage people from trashing their system
(This applies to all CI_EXEC lines, so I don't think anything is gained from mentioning it here)