fixes #27376 (comment)
this appears to be caused by a more recent version of git being sensitive to mismatched permissions on directories. we didn't notice this before because we were using two separate user accounts to fix up dir permissions in the container , but the second account was removed in #27376
there might be a more elegant way to do this, but this does the trick and seems to be the way others are fixing this issue around the internets.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto, RandyMcMillan |
| Concept ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
56 | @@ -57,6 +57,9 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then 57 | export CI_EXEC_CMD_PREFIX="docker exec ${CI_CONTAINER_ID}" 58 | $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ci_base_install/ "${BASE_ROOT_DIR}" 59 | $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ro_base/ "$BASE_ROOT_DIR" 60 | + # Fixes permission issues when there is a container UID/GID mismatch with the owner 61 | + # # of the mounted bitcoin src dir.
A stray #?
fixed
ACK 2c11e94131447bc605b7698a80d02c2523497a4b, tested on Ubuntu 22.04.
re-ACK ed4a8339b8fe796b4668e206d7fb9c2b120f8eb2
Concept ACK - will test
ACK ed4a833
56 | @@ -57,6 +57,9 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then 57 | export CI_EXEC_CMD_PREFIX="docker exec ${CI_CONTAINER_ID}" 58 | $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ci_base_install/ "${BASE_ROOT_DIR}" 59 | $CI_EXEC_CMD_PREFIX rsync --archive --stats --human-readable /ro_base/ "$BASE_ROOT_DIR" 60 | + # Fixes permission issues when there is a container UID/GID mismatch with the owner 61 | + # of the mounted bitcoin src dir. 62 | + $CI_EXEC_CMD_PREFIX git config --global --add safe.directory "*"
Not sure if it matters, but it could make sense to run this even when CI is run without the docker wrapper. Probably this doesn't affect anyone, but less conditional code seems a win by itself.
lgtm