test: added coverage to rpc_scantxoutset.py #27453

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:test/scantxoutsetInvalid changing 1 files +3 −0

kevkevinpal commented at 3:59 PM on April 12, 2023: contributor

Included a test that checks if an invalid first argument is entered we receive a rpc error. The rpc should fail if "start", "status" or "abort" is not the first command.

Relavant: mentioned in #27422
DrahtBot commented at 3:59 PM on April 12, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK MarcoFalke, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Apr 12, 2023
fanquake renamed this:
~~test: added coverage to rpc_cantxoutset.py~~
test: added coverage to rpc_scantxoutset.py
on Apr 12, 2023
ismaelsadeeq commented at 8:23 PM on April 12, 2023: member

LGTM Ack ecb79aed4d847d8c95936ac80b7e137f9c17b6f8
theStack commented at 9:13 AM on May 2, 2023: contributor

Concept ACK,

and warm welcome as a new contributor!

Looks good to me, just one nit: the commit subject line has a missing-character-typo in the functional test filename (rpc_cantxoutset.py -> should be rpc_scantxoutset.py), can you fix that please?
maflcko commented at 10:19 AM on May 2, 2023: member

lgtm ACK ecb79aed4d847d8c95936ac80b7e137f9c17b6f8
bitcoin deleted a comment on May 2, 2023

Type	Reviewers
ACK	MarcoFalke, theStack

test: added coverage to rpc_scantxoutset.py

Included a test that checks if an invalid first argument is entered we
receive a rpc error. The rpc should fail if "start", "status" or "abort"
is not the first command.

24d55fb9cf

kevkevinpal force-pushed on May 2, 2023
kevkevinpal commented at 11:49 AM on May 2, 2023: contributor

Concept ACK,

and warm welcome as a new contributor!

Looks good to me, just one nit: the commit subject line has a missing-character-typo in the functional test filename (rpc_cantxoutset.py -> should be rpc_scantxoutset.py), can you fix that please?

Thanks! Fixed 24d55fb
maflcko commented at 11:50 AM on May 2, 2023: member

lgtm ACK 24d55fb9cfab88f546df35be5c0069b9b645438c
theStack approved
theStack commented at 11:59 AM on May 2, 2023: contributor

ACK 24d55fb9cfab88f546df35be5c0069b9b645438c
fanquake merged this on May 2, 2023
fanquake closed this on May 2, 2023
sidhujag referenced this in commit 8c7fb6f42c on May 4, 2023
bitcoin locked this on May 1, 2024

Contributors

Labels

Linked (view graph)

#27422 test: add coverage to rpc_scantxoutset.py

test: added coverage to rpc_scantxoutset.py #27453

Reviews