The function is unused, not type-safe, and does not denote the underlying clock type. So remove it.
refactor: Remove unused GetTimeMillis #27594
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2305-remove-GetTimeMillis- changing 4 files +6 −22-
maflcko commented at 10:43 AM on May 8, 2023: member
-
fae1d9cded
refactor: Remove unused GetTimeMillis
The function is unused, not type-safe, and does not denote the underlying clock type. So remove it.
-
DrahtBot commented at 10:43 AM on May 8, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK willcl-ark Concept ACK fanquake, hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Refactoring on May 8, 2023
-
fanquake commented at 1:50 PM on May 8, 2023: member
Nice - Concept ACK
- fanquake requested review from willcl-ark on May 8, 2023
-
-
hebasto commented at 3:34 PM on May 8, 2023: member
Concept ACK.
-
willcl-ark commented at 11:24 AM on May 9, 2023: member
tACK fae1d9cded
Also removes
GetSystemTimewhich because unused after faf3f12424.Curious if you have any plans for
GetTime()(marked deprecated since 16046)? - DrahtBot removed review request from willcl-ark on May 9, 2023
-
maflcko commented at 11:43 AM on May 9, 2023: member
Curious if you have any plans for GetTime()
Yeah, I guess it can be removed as well, assuming there are no merge conflicts with other open pulls?
-
fanquake commented at 2:21 PM on May 9, 2023: member
Yeah, I guess it can be removed as well, assuming there are no merge conflicts with other open pulls?
sgtm
- fanquake merged this on May 9, 2023
- fanquake closed this on May 9, 2023
- maflcko deleted the branch on May 9, 2023
- sidhujag referenced this in commit 6c072d708e on May 9, 2023
- bitcoin locked this on May 8, 2024
Contributors
Labels