add ryanofsky to trusted-keys #27604

ryanofsky commented at 3:33 AM on May 9, 2023: contributor

For maintaining interfaces and other areas of the codebase. Some previous discussion in IRC meeting https://gnusha.org/bitcoin-core-dev/2023-05-04.log

add ryanofsky to trusted-keys 59ebee3fb4

DrahtBot commented at 3:33 AM on May 9, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	darosior, hebasto, glozow, pinheadmz, stickies-v, brunoerg, theStack, mzumsande, theuni, jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

darosior commented at 7:48 AM on May 9, 2023: member

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2 for adding ryanofsky as a maintainer.

I have not checked the key 4D1B3D5ECBA1A7E05371EEBE46800E30FC748A66. -----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEWQtykmla/6W2csuy4T/BRc0/QwQFAmRZ+qsACgkQ4T/BRc0/ QwT3lQv/Qud7HqLisikdjcg7jrqa9YBS5j8CwFFIJW5TpY5zqLsm/7nI8RlkakRg gvj1Ok92RTnhEGaleN/80Bco9uH5PEW+6V0tda5ZS/VqD4P0l3Jra9U0kvnTeWAR aFRWCK14nelsU2+ccG0cf0yHnqrX3/jJGzINJzx2nJt1xDNVKxrkqahYSZfeNa3q 9CZdmxbVTswCyH9kkLdN8iSs80xcHufO+S11W14PtHd71vxzivAM/5MKb2FT0L3p vQxQpw4mzPoM5QPr5zbtWsuGEAOT9OjbnrGVINsHXDJZEscJdLaNhNtJBsV7WM8U 25GYDMM4wW8V1KFlpaZpAyS6/J0kWh2ekgl7ZUjOTnQNqxKJMKDLwxLtb0Bm2OvA 2g2SES1kJ9h4fMYGc666zzicEem3ytnqADB/gR1pbFcYZINi1rB3xyqBw+lFeV/5 LinoM/DODXQSz6VIdeDOQvZCXN/6qwiroCx2QwqHndOFMNqPmRQI2LlwYdhtaE0m dv9e3fmt =KLkd -----END PGP SIGNATURE-----

hebasto approved

hebasto commented at 9:06 AM on May 9, 2023: member

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

My local gpg output:

$ gpg --list-keys 4D1B3D5ECBA1A7E05371EEBE46800E30FC748A66
pub   rsa4096 2022-01-07 [SC] [expires: 2024-01-07]
      4D1B3D5ECBA1A7E05371EEBE46800E30FC748A66
uid           [ unknown] Ryan Ofsky <ryan@ofsky.org>
sub   rsa4096 2022-01-07 [E] [expires: 2024-01-07]

glozow commented at 1:19 PM on May 9, 2023: member

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

I feel that we need an "interfaces" maintainer with a deep understanding of our codebase's architecture (how it is and how it should be), particularly as we are working on several large projects spanning multiple subsystems and figuring out how to separate them. I believe @ryanofksy is this person, and generally a natural fit for having merge access because he is one of the most consistent and thorough reviewers on the project.

This key fingerprint matches what is in my keychain.

pinheadmz approved

pinheadmz commented at 1:52 PM on May 9, 2023: member

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

I verified the key fingerprint in meatspace with the human that I believe is, in fact, @ryanofsky. Confirmed fingerprint matches key that signed this commit.

ryanofsky will be a great maintainer, his reviews are excellent even on PRs that he doesn't agree with.

<details><summary>Show Signature</summary>

pinheadmz's public key is on keybase

</details>

stickies-v approved

stickies-v commented at 2:29 PM on May 9, 2023: contributor

utACK https://github.com/bitcoin/bitcoin/commit/59ebee3fb4181baf20fab263cf1b587ece1bd5e2

ryanofsky has consistently proven to be extremely skilled, thorough and helpful. Even though he's comfortable being opinionated, I always find his discourse respectful and well balanced. His PRs and reviews often serve as a benchmark for how things should be done, for me. I think he has the right attributes for being successful as a maintainer.

I cannot verify his key as I do not have it in my keyring.

Thank you for taking this on, ryanofsky!

brunoerg approved

brunoerg commented at 5:15 PM on May 9, 2023: contributor

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Strongly agree on adding @ryanofsky on it.

theStack approved

theStack commented at 6:00 PM on May 9, 2023: contributor

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

mzumsande commented at 7:19 PM on May 9, 2023: contributor

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

theuni approved

theuni commented at 8:20 PM on May 9, 2023: member

ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2.

jarolrod approved

jarolrod commented at 3:05 AM on May 10, 2023: member

ACK https://github.com/bitcoin/bitcoin/commit/59ebee3fb4181baf20fab263cf1b587ece1bd5e2

fanquake merged this on May 10, 2023

fanquake closed this on May 10, 2023

josibake commented at 10:56 AM on May 10, 2023: member

post-merge ACK https://github.com/bitcoin/bitcoin/commit/59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Solid track record of review and work on the project. Aside from the obvious fit for an interfaces maintainer, ryanofsky has a track record of thorough review and being able to clearly articulate his reasoning

Sjors commented at 12:02 PM on May 10, 2023: member

Concept ACK. I can't verify the PGP key.

0xB10C commented at 12:36 PM on May 10, 2023: contributor

post-merge ACK

Zero-1729 commented at 2:18 PM on May 10, 2023: contributor

Post merge ACK 59ebee3fb4181baf20fab263cf1b587ece1bd5e2

Verified key fingerprint checks out in my local keychain.

jamesob commented at 2:27 PM on May 10, 2023: member

PO27970686-front-cu

I'm also unable to verify the GPG key.

LarryRuane commented at 3:49 PM on May 10, 2023: contributor

post-merge ACK

michaelfolkson commented at 4:14 PM on May 10, 2023: contributor

For posterity: https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2023-May/021618.html

michaelfolkson commented at 10:46 AM on May 11, 2023: contributor

Also for posterity: https://gist.github.com/michaelfolkson/81df14508ed3ad3232da133e154d6873

The maintainer role was always supposed to be janitorial one and was not elevated above the many long term contributors on the project. A hundred(s) billion dollar ecosystem shouldn't depend on the whims of a small group of maintainers who refuse to engage on decisions that not only impact the project but potentially the entire ecosystem (currently valued in the hundreds of billions of dollars). The fact that I'm the only one here stating the obvious (as I was for the CTV activation chaos) is really scary to me. I'm hoping many of those long term contributors are involved in private discussions with the maintainers I'm not privy to. If they aren't they really should be as concerned as I am.

stickies-v commented at 11:10 AM on May 11, 2023: contributor

The fact that I'm the only one here stating the obvious (...) is really scary to me.

Not to speak for anyone else, but perhaps the lack of engagement on your messages is because most regular contributors are just generally happy with the maintainer decisions and don't agree with your assessment but do not wish to keep discussing the same thing time and again?

michaelfolkson commented at 11:36 AM on May 11, 2023: contributor

Not to speak for anyone else, but perhaps the lack of engagement on your messages is because most regular contributors are just generally happy with the maintainer decisions and don't agree with your assessment but do not wish to keep discussing the same thing time and again?

It is a failure of communication and process around both CTV (which could have resulted in a chain split disrupting a hundred(s) billion dollar ecosystem) and now the addition, rejection and removal of maintainers. If you and others don't think that stuff is important I don't know what to tell you. You are unfortunately completely missing the bigger picture. To assume Vasil and other long term contributors are happy with the situation is also a rather significant assumption.

bitcoin locked this on May 10, 2024