[24.1] Backports for rc3 #27614

1. 
   fanquake commented at 9:38 am on May 10, 2023: member

   Backports for rc3. Currently:

   • #27608
   • https://github.com/bitcoin/bitcoin/pull/27610
2. fanquake added this to the milestone 24.1 on May 10, 2023
3. 
   DrahtBot commented at 9:38 am on May 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	josibake, glozow, dergoegge, brunoerg, hebasto, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on May 10, 2023
5. fanquake renamed this:
   [24.x] Backports for rc3
   [24.1] Backports for rc3
   on May 11, 2023
6. p2p: Avoid prematurely clearing download state for other peers

   Github-Pull: #27608
   Rebased-From: 52e52071e01f4e98d87a47e1d5f3c5c3cc6dbaf4

   ec7cd33c9c
7. txmempool: have CompareDepthAndScore sort missing txs first

   We use CompareDepthAndScore to choose an order of txs to inv. Rather
   than sorting txs that have been evicted from the mempool at the end
   of the list, sort them at the beginning so they are removed from
   the queue immediately.
   
   Github-Pull: #27610
   Rebased-From: 228e9201efb5574b1b96bb924de1d2e8dd1317f3

   a9a861af2b
8. net_processing: Boost inv trickle rate

   If transactions are being added to the mempool at a rate faster than 7tx/s
   (INVENTORY_BROADCAST_PER_SECOND) then peers' inventory_to_send queue can
   become relatively large. If this happens, increase the number of txids
   we include in an INV message (normally capped at 35) by 5 for each 1000
   txids in the queue.
   
   This will tend to clear a temporary excess out reasonably quickly; an
   excess of 4000 invs to send will be cleared down to 1000 in about 30
   minutes, while an excess of 20000 invs would be cleared down to 1000 in
   about 60 minutes.
   
   Github-Pull: #27610
   Rebased-From: 5b3406094f2679dfb3763de4414257268565b943

   128da6e41f
9. build: bump version to v24.1rc3 abb9fa0c81
10. doc: update manual pages for v24.1rc3 7e9c7ae810
11. doc: update release notes for 24.1rc3 97f5e28830
12. fanquake force-pushed on May 11, 2023
13. 
    josibake commented at 1:45 pm on May 11, 2023: member

    ACK https://github.com/bitcoin/bitcoin/pull/27614/commits/97f5e28830dfa5786cdc5df62e245e03fa393e19

    Verified that the commits added are the correct ones from the PRs linked, compiled and ran the tests. Document changes look good. Looks like the CI failures are just github being crappy

14. 
    glozow commented at 2:41 pm on May 11, 2023: member

    ACK 97f5e28830dfa5786cdc5df62e245e03fa393e19
15. 
    dergoegge commented at 2:42 pm on May 11, 2023: member

    ACK 97f5e28830dfa5786cdc5df62e245e03fa393e19
16. brunoerg approved
17. 
    brunoerg commented at 2:47 pm on May 11, 2023: contributor

    ACK 97f5e28830dfa5786cdc5df62e245e03fa393e19

    Just ran the tests locally, no problem. Release notes ok.

18. hebasto approved
19. 
    hebasto commented at 2:55 pm on May 11, 2023: member

    ACK 97f5e28830dfa5786cdc5df62e245e03fa393e19, commits were backported locally, got zero diff.
20. 
    achow101 commented at 2:57 pm on May 11, 2023: member

    ACK 97f5e28830dfa5786cdc5df62e245e03fa393e19
21. achow101 merged this on May 11, 2023
22. achow101 closed this on May 11, 2023

    ---

23. fanquake deleted the branch on May 11, 2023
24. bitcoin locked this on May 10, 2024

Contributors
fanquake DrahtBot josibake glozow dergoegge brunoerg hebasto achow101

Labels
Backport

Milestone
24.1