msvc: Rename libbitcoinconsensus to libbitcoin_consensus and other adjustments #27615

1. 
   hebasto commented at 10:24 am on May 10, 2023: member

   The current Autotools-based build system operates with two build artifacts:

   • LIBBITCOIN_CONSENSUS which is defined as “Stable, backwards-compatible consensus functionality used by libbitcoin_node and libbitcoin_wallet”
   • LIBBITCOINCONSENSUS which is defined as “Shared library build of static libbitcoin_consensus library”

   The way how the libbitcoinconsensus.vcxproj project is used in the MSVC build system obviously shows that it is the former use case.

   This PR makes the related adjustments to the MSVC build system.

2. 
   DrahtBot commented at 10:24 am on May 10, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipsorcery

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #24773 (Enable HW-accelerated implementations of SHA256 for MSVC builds by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. scripted-diff: Rename `libbitcoinconsensus` to `libbitcoin_consensus`

   This build artifact is not a user-exposed shared library (DLL) but a
   convenience static library.
   See: https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md
   
   -BEGIN VERIFY SCRIPT-
   sed -i 's/libbitcoinconsensus/libbitcoin_consensus/g' $(git grep -l "libbitcoinconsensus" -- build_msvc)
   git mv build_msvc/libbitcoinconsensus build_msvc/libbitcoin_consensus
   git mv build_msvc/libbitcoin_consensus/libbitcoinconsensus.vcxproj build_msvc/libbitcoin_consensus/libbitcoin_consensus.vcxproj
   -END VERIFY SCRIPT-

   30aee016f1
4. msvc: Clean up `libbitcoin_consensus` source files

   See `libbitcoin_consensus_a_SOURCES` in the `src/Makefile.am`.

   cf6ff1031b
5. msvc: Do not define `HAVE_CONSENSUS_LIB`

   The `HAVE_CONSENSUS_LIB` symbol is supposed to be defined when a
   user-exposed shared library (DLL) is built which is not the case here.

   a94d75fa81
6. hebasto force-pushed on May 10, 2023
7. DrahtBot added the label CI failed on May 10, 2023
8. DrahtBot removed the label CI failed on May 12, 2023
9. fanquake requested review from sipsorcery on May 16, 2023
10. hebasto added the label Windows on May 16, 2023
11. hebasto added the label Build system on May 16, 2023
12. 
    fanquake commented at 8:52 am on May 17, 2023: member

    Other than renaming things, what does this acheive? Unclear it’s worth doing if everything done here is going to be thrown away when we switch to CMake.
13. 
    hebasto commented at 9:07 am on May 17, 2023: member

    Other than renaming things, what does this acheive?

    It is required for #24773.

    Unclear it’s worth doing if everything done here is going to be thrown away when we switch to CMake.

    Sure. Not a priority at all.

14. 
    sipsorcery commented at 7:21 pm on May 17, 2023: member

    As the rename makes the naming more correct seems reasonable to me.

    ACK a94d75fa81bab8f4695ab1756524e639af0ff69c.

15. DrahtBot removed review request from sipsorcery on May 17, 2023
16. sipsorcery approved
17. fanquake merged this on May 18, 2023
18. fanquake closed this on May 18, 2023

    ---

19. hebasto deleted the branch on May 18, 2023
20. sidhujag referenced this in commit 494027892a on May 19, 2023
21. bitcoin locked this on May 17, 2024

Contributors
hebasto DrahtBot fanquake sipsorcery

Labels
Windows Build system