CI_EXEC has many issues:
bash -c "$*", meaning that the full command will be treated as a single string, ignoring tokens.Fix all issues by removing it almost completely.
[WARN] The commit is obviously broken and will not run the CI system. In
the rare case this is hit in a git bisect, just skip the commit.
The goal here was to make it trivial to review with the git option:
--color-moved=dimmed-zebra
It is required to move everything into one file because "exit 0" will
otherwise stop working as intended when the containing bash script is no
longer executed with "source ...".
If there is desire to split up 06_script_b.sh into logical chunks in the
future, it will also be easier after the following commit.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | TheCharlatan |
| Concept ACK | RandyMcMillan, fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
concept ACK
Concept ACK
80 | + make distclean || true 81 | + ./autogen.sh 82 | + bash -c "./configure $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG" || ( (cat config.log) && false) 83 | + make "${MAKEJOBS}" && cd src/qt && ANDROID_HOME=${ANDROID_HOME} ANDROID_NDK_HOME=${ANDROID_NDK_HOME} make apk 84 | + bash -c "${PRINT_CCACHE_STATISTICS}" 85 | + exit 0
Moving the exit 0 may also fix a bug where the CI Pod for ARM64 Android APK [jammy] is left alive even if the test passed.
ACK fa01c3c59cbe28be0751c2956609907ecfbcbe49