25.0 Final Changes #27686

1. 
   fanquake commented at 12:11 pm on May 17, 2023: member

   Final changes for v25.0. PR for bitcoincore.org is here: https://github.com/bitcoin-core/bitcoincore.org/pull/970.
2. fanquake added this to the milestone 25.0 on May 17, 2023
3. 
   DrahtBot commented at 12:11 pm on May 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge
   Stale ACK	josibake, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on May 17, 2023
5. build: bump version to v25.0 final 8f7db443e9
6. doc: update manual pages for 25.0 51195ea570
7. fanquake renamed this:
   [25.x] Changes for rc3 || finalize
   25.0 Final Changes
   on May 19, 2023
8. fanquake force-pushed on May 19, 2023
9. fanquake marked this as ready for review on May 19, 2023
10. fanquake force-pushed on May 19, 2023
11. DrahtBot added the label CI failed on May 19, 2023
12. in doc/release-notes.md:294 in 9ded442dff outdated

    292+- MarcoFalke
    293+- Martin Leitner-Ankerl
    294+- Martin Zumsande
    295+- Matt Whitlock
    296+- Matthew Zipkin
    297+- merge-script
    

    ---

    ---

    

    josibake commented at 12:42 pm on May 19, 2023:

    lol credit where credit is due, i guess?
13. 
    josibake commented at 12:43 pm on May 19, 2023: member

    ACK https://github.com/bitcoin/bitcoin/pull/27686/commits/9ded442dffb827d8762c0becce9d10fa283d1a3a

    looks good, although we probably don’t need to credit merge-script as a contributor

14. fanquake force-pushed on May 19, 2023
15. 
    josibake commented at 12:53 pm on May 19, 2023: member

    reACK https://github.com/bitcoin/bitcoin/pull/27686/commits/6675cf809543866792bf6706372fc9ac253d3e99
16. in doc/release-notes.md:200 in 6675cf8095 outdated

    198+----
    199+
    200+- The binary verification script has been updated. In previous releases it
    201+  would verify that the binaries had been signed with a single "release key".
    202+  In this release and moving forward it will verify that the binaries are
    203+  signed by a _threshold of trusted keys_. For more detairs and
    

    ---

    ---

    

    vostrnad commented at 2:09 pm on May 19, 2023:

    0  signed by a _threshold of trusted keys_. For more details and
    

    ---

    

    fanquake commented at 2:18 pm on May 19, 2023:

    Thanks. Fixed.
17. fanquake force-pushed on May 19, 2023
18. DrahtBot removed the label CI failed on May 19, 2023
19. 
    theStack commented at 10:14 am on May 24, 2023: contributor

    Release notes for the new scanblocks RPC (https://github.com/bitcoin/bitcoin/pull/23549) are currently missing, could take what @kouloumos prepared in the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/scanblocks-RPC-release-notes (https://github.com/bitcoin/bitcoin/pull/23549#issuecomment-1277753723).
20. doc: update release notes for 25.0 6ee3881551
21. fanquake force-pushed on May 24, 2023
22. 
    fanquake commented at 10:31 am on May 24, 2023: member

    Release notes for the new scanblocks RPC (https://github.com/bitcoin/bitcoin/pull/23549) are currently missing,

    Pulled them in, and deleted the wiki page.

23. 
    achow101 commented at 4:18 pm on May 24, 2023: member

    ACK ac8d72668c7bbd9f8771442fe25fd37f08c3f5ae
24. 
    dergoegge commented at 9:42 am on May 25, 2023: member

    ACK 6ee3881551f2cd411c4e4d8b0ccedf0f0416d8c2
25. DrahtBot requested review from achow101 on May 25, 2023
26. DrahtBot requested review from josibake on May 25, 2023
27. fanquake merged this on May 25, 2023
28. fanquake closed this on May 25, 2023

    ---

29. fanquake deleted the branch on May 25, 2023
30. Jones098 approved
31. bitcoin locked this on Aug 9, 2024

Contributors
fanquake DrahtBot josibake vostrnad theStack achow101 dergoegge Jones098

Review Requested
achow101 josibake

Labels
Backport

Milestone
25.0