msvc: Provide ObjectFileName explicitly #27687

1. 
   hebasto commented at 12:40 pm on May 17, 2023: member

   This PR is a follow-up to #26715.

   Fixes intermittent MSVC link errors.

2. hebasto added the label Windows on May 17, 2023
3. hebasto added the label Build system on May 17, 2023
4. 
   DrahtBot commented at 12:40 pm on May 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	sipsorcery

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   fanquake commented at 1:17 pm on May 17, 2023: member

   Can you explain what the issue currently is, and why this is the right fix (as opposed to https://github.com/bitcoin-core/gui/pull/729)? Seems odd to have intermittent link failures.
6. 
   hebasto commented at 1:56 pm on May 17, 2023: member

   Can you explain what the issue currently is, and why this is the right fix

   The issue is the file name conflict.

   See https://api.cirrus-ci.com/v1/task/6646912535756800/logs/build.log:

   0C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(1098,5): warning MSB8027: Two or more files with the name of util.cpp will produce outputs to the same location. This can lead to an incorrect build result.  The files involved are ..\..\src\wallet\test\util.cpp, ..\..\src\qt\test\util.cpp. [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\build_msvc\test_bitcoin-qt\test_bitcoin-qt.vcxproj]
   

   as opposed to bitcoin-core/gui#729

   Well, it was a blind shot… But the code change was correct and actual an improvement.

7. hebasto force-pushed on May 17, 2023
8. msvc: Provide `ObjectFileName` explicitly

   Should fix intermittent MSVC link errors.

   b8ed95127b
9. hebasto force-pushed on May 17, 2023
10. DrahtBot added the label CI failed on May 17, 2023
11. hebasto marked this as ready for review on May 17, 2023
12. 
    hebasto commented at 2:23 pm on May 17, 2023: member

    MSVC build is free from MSB8027 now.
13. DrahtBot removed the label CI failed on May 17, 2023
14. fanquake requested review from sipsorcery on May 18, 2023
15. 
    hebasto commented at 10:13 am on May 19, 2023: member

    Friendly ping @sipsorcery :)
16. 
    sipsorcery commented at 11:30 am on May 19, 2023: member

    ACK b8ed95127b23873db973b2ef4f68d9f04e9c23ae.

    Same object file name change has to be done in other places in the msvc build and doesn’t affect the final build artifcat.

17. DrahtBot removed review request from sipsorcery on May 19, 2023
18. sipsorcery approved
19. fanquake merged this on May 19, 2023
20. fanquake closed this on May 19, 2023

    ---

21. hebasto deleted the branch on May 19, 2023
22. sidhujag referenced this in commit f0308535cc on May 19, 2023
23. bitcoin locked this on May 18, 2024

Contributors
hebasto DrahtBot fanquake sipsorcery

Labels
Windows Build system