random: drop syscall wrapper usage for getrandom() #27699

fanquake commented at 4:12 PM on May 18, 2023: member

This requires a linux kernel of 3.17+, which seems entirely reasonable. 3.17 went EOL in 2015, and the last supported 3.x kernel (3.16) went EOL > 4 years ago, in 2020. For reference, the current oldest maintained kernel is 4.14 (released 2017, going EOL Jan 2024).

Support for getrandom() (and getentropy()) was added to glibc 2.25 https://sourceware.org/legacy-ml/libc-alpha/2017-02/msg00079.html:

The getentropy and getrandom functions, and the <sys/random.h> header file have been added.

and we already require 2.27 or later.

All that being said, I don't think you would encounter a current day (+~6 months from now) system, running with kernel headers older than 3.17 (released 2014) but also having a glibc of 2.27+ (released 2018)?

Removing this (our only) use of syscall() also means we can drop a workaround in our MSAN jobs. If this is merged, I'll drop the same workaround in oss-fuzz.

fanquake added the label DrahtBot Guix build requested on May 18, 2023

DrahtBot commented at 4:12 PM on May 18, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, josibake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label CI failed on May 18, 2023

DrahtBot removed the label DrahtBot Guix build requested on May 19, 2023

in src/random.cpp:292 in 49f44a69cd outdated

 302 | -        } else {
 303 | -            RandFailure();
 304 | -        }
 305 | +    if (getrandom(ent32, NUM_OS_RANDOM_BYTES, 0) != NUM_OS_RANDOM_BYTES) {
 306 | +        RandFailure();
 307 |      }

maflcko commented at 6:12 AM on May 19, 2023:

    }
    // Silence a compiler warning about unused function.
    (void)GetDevURandom;

fanquake commented at 9:30 AM on May 19, 2023:

Added [[maybe_unused]] to GetDevURandom.

fanquake force-pushed on May 19, 2023

fanquake commented at 9:32 AM on May 19, 2023: member

Added a commit to use [[maybe_unused]] on GetDevURandom, rather than adding another instance of (void)GetDevURandom, to silence a warning.

Added a commit to slightly refactor getentropy() detection on macOS, so that we can combine the #ifdefs for the sys/random.h include.

DrahtBot added the label DrahtBot Guix build requested on May 19, 2023

DrahtBot removed the label CI failed on May 19, 2023

fanquake commented at 11:11 AM on May 19, 2023: member

Guix Build:

15e52e32e8ad2574fa5a1bd5e7699f33b7084a63d4ed3951a9b9f22632dd57fb  guix-build-f33211a4fe56/output/aarch64-linux-gnu/SHA256SUMS.part
1c981a6d7cce696f4b562443ef53f401dfa6edc4704154f453ee4f66b8fc72d6  guix-build-f33211a4fe56/output/aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu-debug.tar.gz
c8d0b81e5ad5f504650690c9b0192338b22a09aeead9cc1a48054e228704f1a8  guix-build-f33211a4fe56/output/aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu.tar.gz
4e59bc9cbe2499fd415ab1b9eeab40d090cb19aae2df2eee1f978c5ec01b8e63  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/SHA256SUMS.part
49b76219924fa46c7df008a5c36aa54f226f57223863e9da7be393f30f327475  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf-debug.tar.gz
71173c84fc02728c53d3cd02569f1767611544fa501929a91c17545647e8b436  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf.tar.gz
77a976c916ef30925e6b192d5ef49d1d8d1b3fe9aa3908c6b9b1373a0542657a  guix-build-f33211a4fe56/output/arm64-apple-darwin/SHA256SUMS.part
4e655cf22f003455a14edd9408ea8f2620f39185a7e400664768bba3de0d0f8f  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.dmg
db7a9a84d2b3d546bef11ed8f9bc63fe319133427a1c1033fbc962f44dd5cfcb  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.tar.gz
df293de71a8c59767111a6353ade25a2d470fca1991cba06949a73667cc46ff9  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin.tar.gz
f59ce5b708a69ab9cfe80936a70e2f33490328b2eb16a31d6dd75f4655dad2da  guix-build-f33211a4fe56/output/dist-archive/bitcoin-f33211a4fe56.tar.gz
aa2e1e6ebf6e781410660e8fc7ee71c568fdd849fbc6d2edf16dbf52936a8d9b  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/SHA256SUMS.part
cb5501376f3f23259b68c0a043f68d0adf39f9c5fb3daa734d2947c01135c5a1  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu-debug.tar.gz
986b1c06a16b9850de514eed315bb8ccd911148b2696a8e6c816de767696de24  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu.tar.gz
c2f4cd7bbfc4520f72862f7820a304a5610c5484c112a45247d21252af78d400  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/SHA256SUMS.part
e859c2f48937729752cbf066bc661e427e90a5fde28f21d4ef985d8f29cf6bc5  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu-debug.tar.gz
dcdfca6c1220828035d0d8be64baf327165143971abb9cec6aae2c498bbd9432  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu.tar.gz
a77bd1100669c1af1d3106b89d4a78cb526d072d6cfdb8465d93338783e85c18  guix-build-f33211a4fe56/output/riscv64-linux-gnu/SHA256SUMS.part
51cccb85c3a407be2da35820eeb40eef2608041ad62f831a643d01654462ea9f  guix-build-f33211a4fe56/output/riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu-debug.tar.gz
b5b5a801fed7544720734415d11f1595384d2ee5f7ebd142c20396ee7d16d860  guix-build-f33211a4fe56/output/riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu.tar.gz
1818901a04e8bf65c74c3acd827785ee13bcf2473ee60dfae5e130fe3794eb15  guix-build-f33211a4fe56/output/x86_64-apple-darwin/SHA256SUMS.part
c8232b9c439f8e2d7cc461b0c5f26cd2fe95f49a9ae946d55b4fafe429a3768a  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.dmg
a41eacbdcd5df69a91ebc79423b278289b639251c85ef287d59c41b0c516b8bb  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.tar.gz
c615b6c7186387d9e5c0391ad3d09fc4f9b01a5a3ae1a60bfa7d7cb03efd0ba1  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin.tar.gz
6c7c8ab4bd739dbd6334bfebbe9a5f9105fdb3d1796a214fde7673889d4866e6  guix-build-f33211a4fe56/output/x86_64-linux-gnu/SHA256SUMS.part
465e8facee7866379a0b5e766d3aad288f0ae8b5cbd58c15c5692968c8eac178  guix-build-f33211a4fe56/output/x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu-debug.tar.gz
4c71815664f197b4ca373c506958c124b3bf340c8e57eb8659d6330ab8f4055f  guix-build-f33211a4fe56/output/x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu.tar.gz
a1f608382d9f9e43f1305ff3456a37a1adeb0ef48f9a97e8eac1374bf56be459  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/SHA256SUMS.part
ed976f91d0f55dec43d87312779c0e871b8a10638a490d7c95906760173cef1d  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-debug.zip
2006c8094f95a059fde52f2249da0b7917f3d00919eed523808468a431d221b7  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-setup-unsigned.exe
03779f3b39bd5ffb89fc4371c0d2041f7042ff2ee1eddc761fda3ab467c76148  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-unsigned.tar.gz
e4047bb5949b3b1815b9e6215ba5b1224b8e389e2caaeaf03a6d3d935c4a96e7  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64.zip

DrahtBot commented at 5:08 PM on May 19, 2023: contributor

Guix builds

File	commit fc4bee3f196e9b4685b62b5e2ecb83a6bc33676a<br>(master)	commit 599df1fd042659561b7d51fab0445c2db1f3b948<br>(master and this pull)
SHA256SUMS.part	`3233be5c209caee1...`	`5439f27151bfbffa...`
*-aarch64-linux-gnu-debug.tar.gz	`eea6e3ca65ffe0f3...`	`312b8d79f58ec7e2...`
*-aarch64-linux-gnu.tar.gz	`df6bcaeb303c301b...`	`866a646116497122...`
*-arm-linux-gnueabihf-debug.tar.gz	`e2e00c6810f5f027...`	`60c0f651835f1ecb...`
*-arm-linux-gnueabihf.tar.gz	`0a81556d1b2fb793...`	`d1b689a42bfb62cd...`
*-powerpc64-linux-gnu-debug.tar.gz	`41e598bb25afd26b...`	`b0bdb2bd11c3d621...`
*-powerpc64-linux-gnu.tar.gz	`01e32bd786bbf986...`	`f119e31444ad4c7f...`
*-powerpc64le-linux-gnu-debug.tar.gz	`b9b51523ddf9bdac...`	`94dae31e2f88d497...`
*-powerpc64le-linux-gnu.tar.gz	`9d0700a7d17e9cc9...`	`bad58fd187dc03d5...`
*-riscv64-linux-gnu-debug.tar.gz	`a621bf1db1d1782d...`	`a8deadecaeb4b0d7...`
*-riscv64-linux-gnu.tar.gz	`712a05982fd78ab8...`	`e5c1403a0af16e9d...`
*-x86_64-linux-gnu-debug.tar.gz	`a6caf0fd608089bb...`	`dde5e551ea560e06...`
*-x86_64-linux-gnu.tar.gz	`95068f4388347b73...`	`b079748dc8db8072...`
*.tar.gz	`cda587918529f6d6...`	`d5e125ee19767300...`
guix_build.log	`92fc0fbd0381435c...`	`97cdc7d8dbcb0e55...`
guix_build.log.diff		`7d65323f17371ede...`

DrahtBot removed the label DrahtBot Guix build requested on May 19, 2023

josibake commented at 10:23 AM on May 20, 2023: member

ACK https://github.com/bitcoin/bitcoin/pull/27699/commits/f33211a4fe563e03542343ee033d7f5ec7887cbf

Nice to be able to drop the work-around :rocket:

I got the same as you for the guix build:

1c981a6d7cce696f4b562443ef53f401dfa6edc4704154f453ee4f66b8fc72d6  aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu-debug.tar.gz
c8d0b81e5ad5f504650690c9b0192338b22a09aeead9cc1a48054e228704f1a8  aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu.tar.gz
4e655cf22f003455a14edd9408ea8f2620f39185a7e400664768bba3de0d0f8f  arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.dmg
db7a9a84d2b3d546bef11ed8f9bc63fe319133427a1c1033fbc962f44dd5cfcb  arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.tar.gz
df293de71a8c59767111a6353ade25a2d470fca1991cba06949a73667cc46ff9  arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin.tar.gz
49b76219924fa46c7df008a5c36aa54f226f57223863e9da7be393f30f327475  arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf-debug.tar.gz
71173c84fc02728c53d3cd02569f1767611544fa501929a91c17545647e8b436  arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf.tar.gz
e859c2f48937729752cbf066bc661e427e90a5fde28f21d4ef985d8f29cf6bc5  powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu-debug.tar.gz
dcdfca6c1220828035d0d8be64baf327165143971abb9cec6aae2c498bbd9432  powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu.tar.gz
cb5501376f3f23259b68c0a043f68d0adf39f9c5fb3daa734d2947c01135c5a1  powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu-debug.tar.gz
986b1c06a16b9850de514eed315bb8ccd911148b2696a8e6c816de767696de24  powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu.tar.gz
51cccb85c3a407be2da35820eeb40eef2608041ad62f831a643d01654462ea9f  riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu-debug.tar.gz
b5b5a801fed7544720734415d11f1595384d2ee5f7ebd142c20396ee7d16d860  riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu.tar.gz
c8232b9c439f8e2d7cc461b0c5f26cd2fe95f49a9ae946d55b4fafe429a3768a  x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.dmg
a41eacbdcd5df69a91ebc79423b278289b639251c85ef287d59c41b0c516b8bb  x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.tar.gz
c615b6c7186387d9e5c0391ad3d09fc4f9b01a5a3ae1a60bfa7d7cb03efd0ba1  x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin.tar.gz
465e8facee7866379a0b5e766d3aad288f0ae8b5cbd58c15c5692968c8eac178  x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu-debug.tar.gz
4c71815664f197b4ca373c506958c124b3bf340c8e57eb8659d6330ab8f4055f  x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu.tar.gz
ed976f91d0f55dec43d87312779c0e871b8a10638a490d7c95906760173cef1d  x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-debug.zip
2006c8094f95a059fde52f2249da0b7917f3d00919eed523808468a431d221b7  x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-setup-unsigned.exe
03779f3b39bd5ffb89fc4371c0d2041f7042ff2ee1eddc761fda3ab467c76148  x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-unsigned.tar.gz
e4047bb5949b3b1815b9e6215ba5b1224b8e389e2caaeaf03a6d3d935c4a96e7  x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64.zip

hebasto commented at 3:11 PM on May 20, 2023: member

Guix builds:

15e52e32e8ad2574fa5a1bd5e7699f33b7084a63d4ed3951a9b9f22632dd57fb  guix-build-f33211a4fe56/output/aarch64-linux-gnu/SHA256SUMS.part
1c981a6d7cce696f4b562443ef53f401dfa6edc4704154f453ee4f66b8fc72d6  guix-build-f33211a4fe56/output/aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu-debug.tar.gz
c8d0b81e5ad5f504650690c9b0192338b22a09aeead9cc1a48054e228704f1a8  guix-build-f33211a4fe56/output/aarch64-linux-gnu/bitcoin-f33211a4fe56-aarch64-linux-gnu.tar.gz
4e59bc9cbe2499fd415ab1b9eeab40d090cb19aae2df2eee1f978c5ec01b8e63  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/SHA256SUMS.part
49b76219924fa46c7df008a5c36aa54f226f57223863e9da7be393f30f327475  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf-debug.tar.gz
71173c84fc02728c53d3cd02569f1767611544fa501929a91c17545647e8b436  guix-build-f33211a4fe56/output/arm-linux-gnueabihf/bitcoin-f33211a4fe56-arm-linux-gnueabihf.tar.gz
77a976c916ef30925e6b192d5ef49d1d8d1b3fe9aa3908c6b9b1373a0542657a  guix-build-f33211a4fe56/output/arm64-apple-darwin/SHA256SUMS.part
4e655cf22f003455a14edd9408ea8f2620f39185a7e400664768bba3de0d0f8f  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.dmg
db7a9a84d2b3d546bef11ed8f9bc63fe319133427a1c1033fbc962f44dd5cfcb  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin-unsigned.tar.gz
df293de71a8c59767111a6353ade25a2d470fca1991cba06949a73667cc46ff9  guix-build-f33211a4fe56/output/arm64-apple-darwin/bitcoin-f33211a4fe56-arm64-apple-darwin.tar.gz
f59ce5b708a69ab9cfe80936a70e2f33490328b2eb16a31d6dd75f4655dad2da  guix-build-f33211a4fe56/output/dist-archive/bitcoin-f33211a4fe56.tar.gz
aa2e1e6ebf6e781410660e8fc7ee71c568fdd849fbc6d2edf16dbf52936a8d9b  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/SHA256SUMS.part
cb5501376f3f23259b68c0a043f68d0adf39f9c5fb3daa734d2947c01135c5a1  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu-debug.tar.gz
986b1c06a16b9850de514eed315bb8ccd911148b2696a8e6c816de767696de24  guix-build-f33211a4fe56/output/powerpc64-linux-gnu/bitcoin-f33211a4fe56-powerpc64-linux-gnu.tar.gz
c2f4cd7bbfc4520f72862f7820a304a5610c5484c112a45247d21252af78d400  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/SHA256SUMS.part
e859c2f48937729752cbf066bc661e427e90a5fde28f21d4ef985d8f29cf6bc5  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu-debug.tar.gz
dcdfca6c1220828035d0d8be64baf327165143971abb9cec6aae2c498bbd9432  guix-build-f33211a4fe56/output/powerpc64le-linux-gnu/bitcoin-f33211a4fe56-powerpc64le-linux-gnu.tar.gz
a77bd1100669c1af1d3106b89d4a78cb526d072d6cfdb8465d93338783e85c18  guix-build-f33211a4fe56/output/riscv64-linux-gnu/SHA256SUMS.part
51cccb85c3a407be2da35820eeb40eef2608041ad62f831a643d01654462ea9f  guix-build-f33211a4fe56/output/riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu-debug.tar.gz
b5b5a801fed7544720734415d11f1595384d2ee5f7ebd142c20396ee7d16d860  guix-build-f33211a4fe56/output/riscv64-linux-gnu/bitcoin-f33211a4fe56-riscv64-linux-gnu.tar.gz
1818901a04e8bf65c74c3acd827785ee13bcf2473ee60dfae5e130fe3794eb15  guix-build-f33211a4fe56/output/x86_64-apple-darwin/SHA256SUMS.part
c8232b9c439f8e2d7cc461b0c5f26cd2fe95f49a9ae946d55b4fafe429a3768a  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.dmg
a41eacbdcd5df69a91ebc79423b278289b639251c85ef287d59c41b0c516b8bb  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin-unsigned.tar.gz
c615b6c7186387d9e5c0391ad3d09fc4f9b01a5a3ae1a60bfa7d7cb03efd0ba1  guix-build-f33211a4fe56/output/x86_64-apple-darwin/bitcoin-f33211a4fe56-x86_64-apple-darwin.tar.gz
6c7c8ab4bd739dbd6334bfebbe9a5f9105fdb3d1796a214fde7673889d4866e6  guix-build-f33211a4fe56/output/x86_64-linux-gnu/SHA256SUMS.part
465e8facee7866379a0b5e766d3aad288f0ae8b5cbd58c15c5692968c8eac178  guix-build-f33211a4fe56/output/x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu-debug.tar.gz
4c71815664f197b4ca373c506958c124b3bf340c8e57eb8659d6330ab8f4055f  guix-build-f33211a4fe56/output/x86_64-linux-gnu/bitcoin-f33211a4fe56-x86_64-linux-gnu.tar.gz
a1f608382d9f9e43f1305ff3456a37a1adeb0ef48f9a97e8eac1374bf56be459  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/SHA256SUMS.part
ed976f91d0f55dec43d87312779c0e871b8a10638a490d7c95906760173cef1d  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-debug.zip
2006c8094f95a059fde52f2249da0b7917f3d00919eed523808468a431d221b7  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-setup-unsigned.exe
03779f3b39bd5ffb89fc4371c0d2041f7042ff2ee1eddc761fda3ab467c76148  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64-unsigned.tar.gz
e4047bb5949b3b1815b9e6215ba5b1224b8e389e2caaeaf03a6d3d935c4a96e7  guix-build-f33211a4fe56/output/x86_64-w64-mingw32/bitcoin-f33211a4fe56-win64.zip

in doc/dependencies.md:23 in f33211a4fe outdated

  19 | @@ -20,7 +20,7 @@ You can find installation instructions in the `build-*.md` file for your platfor
  20 |  | [Boost](../depends/packages/boost.mk) | [link](https://www.boost.org/users/download/) | [1.81.0](https://github.com/bitcoin/bitcoin/pull/26557) | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No |
  21 |  | [libevent](../depends/packages/libevent.mk) | [link](https://github.com/libevent/libevent/releases) | [2.1.12-stable](https://github.com/bitcoin/bitcoin/pull/21991) | [2.1.8](https://github.com/bitcoin/bitcoin/pull/24681) | No |
  22 |  | glibc | [link](https://www.gnu.org/software/libc/) | N/A | [2.27](https://github.com/bitcoin/bitcoin/pull/27029) | Yes |
  23 | -| Linux Kernel | [link](https://www.kernel.org/) | N/A | 3.2.0 | Yes |
  24 | +| Linux Kernel | [link](https://www.kernel.org/) | N/A | 3.17.0 | Yes |

hebasto commented at 3:33 PM on May 20, 2023:

| Linux Kernel | [link](https://www.kernel.org/) | N/A | [3.17.0](https://github.com/bitcoin/bitcoin/pull/27699) | Yes |

fanquake commented at 4:10 PM on May 20, 2023:

Done.

in configure.ac:1176 in f33211a4fe outdated

1176 | -  #include <sys/syscall.h>
1177 | -  #include <linux/random.h>]],
1178 | - [[ syscall(SYS_getrandom, nullptr, 32, 0); ]])],
1179 | - [ AC_MSG_RESULT([yes]); AC_DEFINE([HAVE_SYS_GETRANDOM], [1], [Define this symbol if the Linux getrandom system call is available]) ],
1180 | +  #include <sys/random.h>]],
1181 | + [[ getrandom(nullptr, 32, 0); ]])],

hebasto commented at 3:44 PM on May 20, 2023:

What Linux systems do require #include <unistd.h> for the getrandom call?

fanquake commented at 3:47 PM on May 20, 2023:

None?

hebasto commented at 4:15 PM on May 20, 2023:

Then may be drop it? (as it done in c13c97dbf846cf0e6a5581ac414ef96a215b0dc6)

fanquake commented at 4:20 PM on May 20, 2023:

Dropped.

hebasto commented at 3:46 PM on May 20, 2023: member

Approach ACK f33211a4fe563e03542343ee033d7f5ec7887cbf.

random: getentropy on macOS does not need unistd.h

Remove it. Make this change, so in a future commit, we can
combine #ifdefs, and avoid duplicate <sys/random.h> includes once we
switch to using getrandom directly.

Also remove the comment about macOS 10.12. We already require macOS >
10.15, so it is redundant.

c13c97dbf8

random: add [[maybe_unused]] to GetDevURandom

Rather than multiple instances of (void)GetDevURandom to silence
compiler warnings.

c2ba3f5b0c

fanquake force-pushed on May 20, 2023

random: switch to using getrandom() directly

This requires a linux kernel of 3.17.0+, which seems entirely
reasonable. 3.17 went EOL in 2015, and the last supported 3.x kernel
(3.16) went EOL > 4 years ago, in 2020. For reference, the current
oldest maintained kernel is 4.14 (released 2017, EOL Jan 2024).

Support for `getrandom()` (and `getentropy()`) was added to
glibc 2.25, https://sourceware.org/legacy-ml/libc-alpha/2017-02/msg00079.html,
and we already require 2.27+.

All that being said, I don't think you would encounter a current day
system, running with kernel headers older than 3.17 (released 2014) but
also having a glibc of 2.27+ (released 2018).

d5e06919db

ci: remove MSAN getrandom syscall workaround

The corresponding workaround will also be dropped in oss-fuzz:
https://github.com/google/oss-fuzz/blob/25946a544856413d31d9cbb3a366a4aef5a8fd60/projects/bitcoin-core/build.sh#L49.

5228223e1f

fanquake force-pushed on May 20, 2023

hebasto approved

hebasto commented at 4:24 PM on May 20, 2023: member

ACK 5228223e1ff2af29e6e77668ce3288005c2adbbc, I've tested build system changes on Ubuntu 22.04 and macOS Monterey 12.6.6 (x86_64).

DrahtBot requested review from josibake on May 20, 2023

hebasto commented at 5:18 PM on May 20, 2023: member

Guix builds:

9dd5852b303462b94703c06d30f432a19769379026c4f61001f452893dbe8121  guix-build-5228223e1ff2/output/aarch64-linux-gnu/SHA256SUMS.part
19f9e24d91522aac6c349dffd4ae5b0386bc15c92767a65eb393e6a42ab5b256  guix-build-5228223e1ff2/output/aarch64-linux-gnu/bitcoin-5228223e1ff2-aarch64-linux-gnu-debug.tar.gz
935f337b5679825aadb004ab0848ba6bae5f7c287f17198faec361eae83e7f1e  guix-build-5228223e1ff2/output/aarch64-linux-gnu/bitcoin-5228223e1ff2-aarch64-linux-gnu.tar.gz
badb4ce4f57e8b27d61aae8e7d0594baf3d7a45144770561312955158b152d29  guix-build-5228223e1ff2/output/arm-linux-gnueabihf/SHA256SUMS.part
0ebb6ef4c311d368786bdad46bdce8b62b6fd2c6071b407961a5d911d0626efe  guix-build-5228223e1ff2/output/arm-linux-gnueabihf/bitcoin-5228223e1ff2-arm-linux-gnueabihf-debug.tar.gz
f0d83bb840b009b4038f2faa55d5aacb71a37e6611255b0f4b627327ee955d17  guix-build-5228223e1ff2/output/arm-linux-gnueabihf/bitcoin-5228223e1ff2-arm-linux-gnueabihf.tar.gz
3a9dbfaaa7b97e660c54ff722f203b3e324ac11d919218739d503765a1f941f8  guix-build-5228223e1ff2/output/arm64-apple-darwin/SHA256SUMS.part
2359e16fd74fa7fcf279a23ab75ccdf652e598e7be131a594137456f9f5df6a8  guix-build-5228223e1ff2/output/arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin-unsigned.dmg
8e6d36685bbea7ae6a8442e94f27605c4fa1ac8be3ef3c9a6e56a1202094dd06  guix-build-5228223e1ff2/output/arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin-unsigned.tar.gz
ea3dd438c0901ec0dc4e74c9300dfa0a1707d3d4dd5bbadb1bf70803bd0da135  guix-build-5228223e1ff2/output/arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin.tar.gz
8ebc6dce4476ec2dbd4d3b2da5d38a5ed303e9205a706084f777064a52826cb0  guix-build-5228223e1ff2/output/dist-archive/bitcoin-5228223e1ff2.tar.gz
aee1b0340c2f971dd5d4c2792af92c1646577fa7f0add8c5771fc302e42052d4  guix-build-5228223e1ff2/output/powerpc64-linux-gnu/SHA256SUMS.part
bc3c891ae090b17c5bdbb4903d10f7b36b4d0d2f5f1f022c64d67d94347daae9  guix-build-5228223e1ff2/output/powerpc64-linux-gnu/bitcoin-5228223e1ff2-powerpc64-linux-gnu-debug.tar.gz
a341248ad365100d8b173cf9204a33458a7c9b87e42492478aef84167a89e47c  guix-build-5228223e1ff2/output/powerpc64-linux-gnu/bitcoin-5228223e1ff2-powerpc64-linux-gnu.tar.gz
aba3f98acd09d01b823f847d007534bba1b9c8cd1fae0b639b908bd0c6216aec  guix-build-5228223e1ff2/output/powerpc64le-linux-gnu/SHA256SUMS.part
5006a51dadd917074d25d10cbd47e760ced291b94bb349d4ec1313af4b01e6d9  guix-build-5228223e1ff2/output/powerpc64le-linux-gnu/bitcoin-5228223e1ff2-powerpc64le-linux-gnu-debug.tar.gz
a61dea868632dc5ba6a80b788a78d0cf7431258d19c3e6ab2ce7f3f7dc31830b  guix-build-5228223e1ff2/output/powerpc64le-linux-gnu/bitcoin-5228223e1ff2-powerpc64le-linux-gnu.tar.gz
9319a9a8f921a0c53032b20ec44589b7fa7a87085c3f04ee1b25d97601714e8c  guix-build-5228223e1ff2/output/riscv64-linux-gnu/SHA256SUMS.part
00643bf494315cedcef86991d78148fc528fb57acc6871ce2e0752d9947ff24c  guix-build-5228223e1ff2/output/riscv64-linux-gnu/bitcoin-5228223e1ff2-riscv64-linux-gnu-debug.tar.gz
7067fd0b6099de8ff065395effe906e3ebbbd8b1f5854f35e5ea66d743d65026  guix-build-5228223e1ff2/output/riscv64-linux-gnu/bitcoin-5228223e1ff2-riscv64-linux-gnu.tar.gz
45d41d87f3d4ea0062a9a1ea62610035c247be5aaf9599e5fb7a071951ff9c2e  guix-build-5228223e1ff2/output/x86_64-apple-darwin/SHA256SUMS.part
d4bfd01fef1bc8111c615332b0453736a32486ff1b84827c1269fd16a3b65488  guix-build-5228223e1ff2/output/x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin-unsigned.dmg
4ec8c5bcca1cc945a4cc6b01e7e8f6a3933392064a32610c387c85191269b73e  guix-build-5228223e1ff2/output/x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin-unsigned.tar.gz
409368ce1b69fc7855ca9bc93c650e50e965313360ffdc04a89571734def5b38  guix-build-5228223e1ff2/output/x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin.tar.gz
739aeaf4456399120ae513b9aabee857d79b92e1a7b6d52f1eda1dd7dea36400  guix-build-5228223e1ff2/output/x86_64-linux-gnu/SHA256SUMS.part
69b711a8720b3c19a08941a3edac7766afc42d0ddd74d42507789e4c43319bcb  guix-build-5228223e1ff2/output/x86_64-linux-gnu/bitcoin-5228223e1ff2-x86_64-linux-gnu-debug.tar.gz
cc508526c6c1649a58982d64457e61a248d9cc469772765fb46466e3f012f9d6  guix-build-5228223e1ff2/output/x86_64-linux-gnu/bitcoin-5228223e1ff2-x86_64-linux-gnu.tar.gz
cf118dc0eeea8ae81ea0c033ac17ff4f9d369515f58855197fbd7a5503161ae1  guix-build-5228223e1ff2/output/x86_64-w64-mingw32/SHA256SUMS.part
f942d956f9ad28632a90987a779ac5143a7661da033a499fa1bef0e11232ad0f  guix-build-5228223e1ff2/output/x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-debug.zip
e69a0d7087ff2aaa9a5c2cb47c946db3134805e064dbc6e681b260a1f99c0e00  guix-build-5228223e1ff2/output/x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-setup-unsigned.exe
186bcd8c01a475c6802c88c5c9cc9b7544a9ded6121d2751ec58f0476a7019f6  guix-build-5228223e1ff2/output/x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-unsigned.tar.gz
40299e5785abbe16c41382c71975e61467c5d6cf12e5181a80325e59b2f9202c  guix-build-5228223e1ff2/output/x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64.zip

josibake commented at 9:14 AM on May 21, 2023: member

Guix builds:

19f9e24d91522aac6c349dffd4ae5b0386bc15c92767a65eb393e6a42ab5b256  aarch64-linux-gnu/bitcoin-5228223e1ff2-aarch64-linux-gnu-debug.tar.gz
935f337b5679825aadb004ab0848ba6bae5f7c287f17198faec361eae83e7f1e  aarch64-linux-gnu/bitcoin-5228223e1ff2-aarch64-linux-gnu.tar.gz
2359e16fd74fa7fcf279a23ab75ccdf652e598e7be131a594137456f9f5df6a8  arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin-unsigned.dmg
8e6d36685bbea7ae6a8442e94f27605c4fa1ac8be3ef3c9a6e56a1202094dd06  arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin-unsigned.tar.gz
ea3dd438c0901ec0dc4e74c9300dfa0a1707d3d4dd5bbadb1bf70803bd0da135  arm64-apple-darwin/bitcoin-5228223e1ff2-arm64-apple-darwin.tar.gz
0ebb6ef4c311d368786bdad46bdce8b62b6fd2c6071b407961a5d911d0626efe  arm-linux-gnueabihf/bitcoin-5228223e1ff2-arm-linux-gnueabihf-debug.tar.gz
f0d83bb840b009b4038f2faa55d5aacb71a37e6611255b0f4b627327ee955d17  arm-linux-gnueabihf/bitcoin-5228223e1ff2-arm-linux-gnueabihf.tar.gz
5006a51dadd917074d25d10cbd47e760ced291b94bb349d4ec1313af4b01e6d9  powerpc64le-linux-gnu/bitcoin-5228223e1ff2-powerpc64le-linux-gnu-debug.tar.gz
a61dea868632dc5ba6a80b788a78d0cf7431258d19c3e6ab2ce7f3f7dc31830b  powerpc64le-linux-gnu/bitcoin-5228223e1ff2-powerpc64le-linux-gnu.tar.gz
bc3c891ae090b17c5bdbb4903d10f7b36b4d0d2f5f1f022c64d67d94347daae9  powerpc64-linux-gnu/bitcoin-5228223e1ff2-powerpc64-linux-gnu-debug.tar.gz
a341248ad365100d8b173cf9204a33458a7c9b87e42492478aef84167a89e47c  powerpc64-linux-gnu/bitcoin-5228223e1ff2-powerpc64-linux-gnu.tar.gz
00643bf494315cedcef86991d78148fc528fb57acc6871ce2e0752d9947ff24c  riscv64-linux-gnu/bitcoin-5228223e1ff2-riscv64-linux-gnu-debug.tar.gz
7067fd0b6099de8ff065395effe906e3ebbbd8b1f5854f35e5ea66d743d65026  riscv64-linux-gnu/bitcoin-5228223e1ff2-riscv64-linux-gnu.tar.gz
d4bfd01fef1bc8111c615332b0453736a32486ff1b84827c1269fd16a3b65488  x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin-unsigned.dmg
4ec8c5bcca1cc945a4cc6b01e7e8f6a3933392064a32610c387c85191269b73e  x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin-unsigned.tar.gz
409368ce1b69fc7855ca9bc93c650e50e965313360ffdc04a89571734def5b38  x86_64-apple-darwin/bitcoin-5228223e1ff2-x86_64-apple-darwin.tar.gz
69b711a8720b3c19a08941a3edac7766afc42d0ddd74d42507789e4c43319bcb  x86_64-linux-gnu/bitcoin-5228223e1ff2-x86_64-linux-gnu-debug.tar.gz
cc508526c6c1649a58982d64457e61a248d9cc469772765fb46466e3f012f9d6  x86_64-linux-gnu/bitcoin-5228223e1ff2-x86_64-linux-gnu.tar.gz
f942d956f9ad28632a90987a779ac5143a7661da033a499fa1bef0e11232ad0f  x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-debug.zip
e69a0d7087ff2aaa9a5c2cb47c946db3134805e064dbc6e681b260a1f99c0e00  x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-setup-unsigned.exe
186bcd8c01a475c6802c88c5c9cc9b7544a9ded6121d2751ec58f0476a7019f6  x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64-unsigned.tar.gz
40299e5785abbe16c41382c71975e61467c5d6cf12e5181a80325e59b2f9202c  x86_64-w64-mingw32/bitcoin-5228223e1ff2-win64.zip

josibake commented at 9:14 AM on May 21, 2023: member

ACK https://github.com/bitcoin/bitcoin/pull/27699/commits/5228223e1ff2af29e6e77668ce3288005c2adbbc

guix builds match hebastos

DrahtBot removed review request from josibake on May 21, 2023

fanquake referenced this in commit 1ea2196a39 on May 22, 2023

fanquake merged this on May 22, 2023

fanquake closed this on May 22, 2023

fanquake deleted the branch on May 22, 2023

fanquake commented at 10:36 AM on May 22, 2023: member

oss-fuzz followup here: https://github.com/google/oss-fuzz/pull/10361.

DavidKorczynski referenced this in commit bd394d0e84 on May 22, 2023

in src/random.cpp:254 in c2ba3f5b0c outdated

 250 | @@ -251,7 +251,7 @@ static void Strengthen(const unsigned char (&seed)[32], SteadyClock::duration du
 251 |  /** Fallback: get 32 bytes of system entropy from /dev/urandom. The most
 252 |   * compatible way to get cryptographic randomness on UNIX-ish platforms.
 253 |   */
 254 | -static void GetDevURandom(unsigned char *ent32)
 255 | +[[maybe_unused]] static void GetDevURandom(unsigned char *ent32)

theuni commented at 12:33 PM on May 22, 2023:

TIL [[maybe_unused]] + static could be used for this effect. Neat :)

theuni commented at 12:44 PM on May 22, 2023: member

Ping @EthanHeilman. Not that I'm worried, but... curious if any part of what you're working on could verify that this is indeed a noop?

sidhujag referenced this in commit 011ce5424d on May 23, 2023

hebasto referenced this in commit be04ac9ebd on Apr 1, 2024

hebasto referenced this in commit 00715fd3a1 on Apr 1, 2024

hebasto referenced this in commit 9397478cd5 on Apr 2, 2024

hebasto referenced this in commit b2c1f64a1e on Apr 2, 2024

bitcoin locked this on May 21, 2024