test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic #27735

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2305-mempool-legacy-wallet- changing 2 files +33 −15
  1. maflcko commented at 6:46 AM on May 24, 2023: member

    This fixes a bug.

    On master:

    $ ./test/functional/mempool_packages.py  --legacy-wallet 
      File "./test/functional/mempool_packages.py", line 52, in run_test
        self.nodes[0].importaddress(self.wallet.get_address())
    test_framework.authproxy.JSONRPCException: Bech32m addresses cannot be imported into legacy wallets (-5)
    

    On this pull, all tests pass.

  2. DrahtBot commented at 6:46 AM on May 24, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK glozow

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Tests on May 24, 2023
  4. maflcko commented at 6:47 AM on May 24, 2023: member

    (An alternative to test this would be to compile with bdb only)

  5. Godonzrepublic commented at 11:40 AM on May 24, 2023: none

    .

  6. bitcoin deleted a comment on May 24, 2023
  7. achow101 commented at 4:47 PM on May 24, 2023: member

    Is there a reason that this test needs the wallet in the first place?

  8. maflcko commented at 7:44 AM on May 25, 2023: member

    Yeah, the test doesn't need the wallet, but it is providing mempool-package coverage for the listunspent wallet RPC. So maybe an alternative would be to move it out into a new test, idk?

  9. fanquake commented at 9:19 AM on May 25, 2023: member

    cc @glozow

  10. glozow commented at 9:38 AM on May 25, 2023: member

    Yeah, the test doesn't need the wallet, but it is providing mempool-package coverage for the listunspent wallet RPC. So maybe an alternative would be to move it out into a new test, idk?

    Would be in favor of moving the listunspent coverage to a new/existing wallet_ functional test instead.

  11. maflcko renamed this:
    test: Disable legacy wallet for mempool_packages.py
    test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic
    on May 26, 2023
  12. DrahtBot renamed this:
    test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic
    test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic
    on May 26, 2023
  13. maflcko force-pushed on May 26, 2023
  14. test: Move test_chain_listunspent wallet check from mempool_packages to wallet_basic ffffe622e9
  15. maflcko force-pushed on May 26, 2023
  16. DrahtBot added the label CI failed on May 26, 2023
  17. maflcko commented at 7:20 AM on May 26, 2023: member

    Thx, done

  18. DrahtBot removed the label CI failed on May 26, 2023
  19. glozow commented at 10:21 AM on May 26, 2023: member

    ACK ffffe622e9cbf926326135bb23958380dcf09df1, thanks for changing! Nice to remove wallet from another non-wallet test.

  20. fanquake merged this on May 26, 2023
  21. fanquake closed this on May 26, 2023

  22. maflcko deleted the branch on May 26, 2023
  23. sidhujag referenced this in commit 4b51a40482 on May 26, 2023
  24. bitcoin locked this on May 25, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me