Fixes #27626 (review) which would have resulted in wasted bandwidth every once in a while.
p2p: Unconditionally return when compact block status == READ_STATUS_FAILED #27743
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:parallel_fail_fix changing 1 files +1 −1-
instagibbs commented at 6:02 PM on May 24, 2023: member
-
Unconditionally return when compact block status == READ_STATUS_FAILED d972695797
-
Sjors commented at 6:10 PM on May 24, 2023: member
utACK d97269579769effbe6eec2303ea0cc3e396d3e0d
-
mzumsande commented at 6:53 PM on May 24, 2023: contributor
ACK d97269579769effbe6eec2303ea0cc3e396d3e0d Agree that it doesn't make sense to continue and send a BLOCKTXN here.
-
DrahtBot commented at 6:04 AM on May 25, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot renamed this:
Unconditionally return when compact block status == READ_STATUS_FAILED
p2p: Unconditionally return when compact block status == READ_STATUS_FAILED
on May 25, 2023 - DrahtBot added the label P2P on May 25, 2023
- fanquake merged this on May 25, 2023
- fanquake closed this on May 25, 2023
- fanquake added the label Needs backport (25.x) on May 25, 2023
- fanquake referenced this in commit 50c86f57af on May 25, 2023
- fanquake removed the label Needs backport (25.x) on May 25, 2023
- sidhujag referenced this in commit 4f72852f81 on May 26, 2023
- Sjors referenced this in commit dcf4e9855e on May 27, 2023
- fanquake referenced this in commit 929af14339 on Jun 2, 2023
- fanquake referenced this in commit b8ad3220a9 on Jun 16, 2023
- fanquake referenced this in commit 8825983716 on Jul 4, 2023
- bitcoin locked this on May 24, 2024