doc: Add doc/release-notes/release-notes-25.0.md #27751

maflcko commented at 11:14 AM on May 25, 2023: member

Also, fix a typo in another doc.

DrahtBot commented at 11:14 AM on May 25, 2023: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake
Stale ACK	stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot renamed this:
~~doc: Add doc/release-notes/release-notes-25.0.md~~
doc: Add doc/release-notes/release-notes-25.0.md
on May 25, 2023

DrahtBot added the label Docs on May 25, 2023

doc: Add doc/release-notes/release-notes-25.0.md faaa97bb38

doc: Fix typo in doc/release-process.md URL fab19a8ae3

in doc/release-notes/release-notes-25.0.md:1 in faf136431d outdated

   0 | @@ -0,0 +1,2 @@
   1 | +Work in progress release notes are on the dev wiki:

fanquake commented at 11:15 AM on May 25, 2023:

Not the release notes?

maflcko force-pushed on May 25, 2023

in doc/release-notes/release-notes-25.0.md:63 in fab19a8ae3 outdated

  58 | +
  59 | +Updated RPCs
  60 | +------------
  61 | +
  62 | +- All JSON-RPC methods accept a new [named
  63 | +  parameter](JSON-RPC-interface.md#parameter-passing) called `args` that can

stickies-v commented at 12:24 PM on May 25, 2023:

broken link:

  parameter](https://github.com/bitcoin/bitcoin/blob/master/doc/JSON-RPC-interface.md#parameter-passing) called `args` that can

maflcko commented at 1:01 PM on May 25, 2023:

Or just /doc/JSON... or ./../JSON...?

stickies-v commented at 1:07 PM on May 25, 2023:

I considered that, but since I think these notes are copy-pasted elsewhere (e.g. bitcoincore.org), I think we generally prefer to stick to absolute links here? At least that's how it is in release-notes-24.0.1.md too.

in doc/release-notes/release-notes-25.0.md:46 in fab19a8ae3 outdated

  41 | +===============
  42 | +
  43 | +P2P and network changes
  44 | +-----------------------
  45 | +
  46 | +- Transactions of non-witness size 65 and above are now allowed by mempool

stickies-v commented at 12:29 PM on May 25, 2023:

nit

- Transactions of non-witness size 65 vbytes and above are now allowed by mempool

maflcko commented at 12:58 PM on May 25, 2023:

No, I don't think it is vbytes, it is non-witness bytes, which is different.

stickies-v commented at 1:02 PM on May 25, 2023:

Ah, good point. bytes, then, as per the PR title? The lack of unit is upsetting high school teachers worldwide.

maflcko commented at 7:46 AM on May 26, 2023:

- Transactions of non-witness size 65 bytes and above are now allowed by mempool

in doc/release-notes/release-notes-25.0.md:88 in fab19a8ae3 outdated

  83 | +
  84 | +- `sendrawtransaction` has a new, optional argument, `maxburnamount` with a default value of `0`.
  85 | +  Any transaction containing an unspendable output with a value greater than `maxburnamount` will
  86 | +  not be submitted. At present, the outputs deemed unspendable are those with scripts that begin
  87 | +  with an `OP_RETURN` code (known as 'datacarriers'), scripts that exceed the maximum script size,
  88 | +  and scripts that contain invalid opcodes.

stickies-v commented at 12:32 PM on May 25, 2023:

  and scripts that contain invalid opcodes. (#25943)

maflcko commented at 7:48 AM on May 26, 2023:

why? There is no list of all pulls in the notes, so the number is without context?

in doc/release-notes/release-notes-25.0.md:132 in fab19a8ae3 outdated

 127 | +
 128 | +  As unused mempool memory is shared with dbcache, this also reduces
 129 | +  the dbcache size for users running with `-blocksonly`, potentially
 130 | +  impacting performance.
 131 | +- Setting `-maxconnections=0` will now disable `-dnsseed`
 132 | +  and `-listen` (users may still set them to override).

stickies-v commented at 12:33 PM on May 25, 2023:

  and `-listen` (users may still set them to override). (#26899)

in doc/release-notes/release-notes-25.0.md:130 in fab19a8ae3 outdated

 125 | +  for users running with `-blocksonly` expecting it to eliminate
 126 | +  mempool memory usage.
 127 | +
 128 | +  As unused mempool memory is shared with dbcache, this also reduces
 129 | +  the dbcache size for users running with `-blocksonly`, potentially
 130 | +  impacting performance.

stickies-v commented at 12:33 PM on May 25, 2023:

  impacting performance. (#26471)

stickies-v approved

stickies-v commented at 12:49 PM on May 25, 2023: contributor

ACK fab19a8ae30c7f2b9347f70f16799e14dc1970b1, confirmed that the release-notes are identical to what was reviewed in https://github.com/bitcoin/bitcoin/pull/27686/

Suggesting some minor improvements to the release notes, but perhaps this is not a suitable place?

fanquake commented at 1:00 PM on May 25, 2023: member

Suggesting some minor improvements to the release notes, but perhaps this is not a suitable place?

They should have been suggested before the notes were finalised in #27686. This is just copying them into master.

doc: Fix broken link in release notes

Also, add missing unit "bytes"

Co-authored-by: stickies-v <69010457+stickies-v@users.noreply.github.com>

034cb5ad4d

maflcko commented at 7:48 AM on May 26, 2023: member

Fixed the broken link. Not sure about the other nits.

fanquake approved

fanquake commented at 10:10 AM on May 26, 2023: member

ACK 034cb5ad4d4b72cf1ba5b153a558fcf6a8afa9aa

DrahtBot requested review from stickies-v on May 26, 2023

fanquake merged this on May 26, 2023

fanquake closed this on May 26, 2023

maflcko deleted the branch on May 26, 2023

sidhujag referenced this in commit 78e4b27256 on May 26, 2023

bitcoin locked this on May 25, 2024