wallet: clarify replace fields in help output #27782

1. 
   torkelrogstad commented at 4:09 PM on May 30, 2023: contributor

   Closes #27781.

2. 
   DrahtBot commented at 4:09 PM on May 30, 2023: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	brunoerg, pinheadmz

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #27307 (wallet: track mempool conflicts with wallet transactions by ishaanam)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Wallet on May 30, 2023
4. DrahtBot added the label CI failed on May 30, 2023
5. DrahtBot removed the label CI failed on May 31, 2023
6. 
   brunoerg commented at 8:54 PM on May 31, 2023: contributor

   I suppose that changing them in TransactionDescriptionString will also affect listsinceblock and listtransactions. So, I think would be appropriate to update the PR title/commit message?

7. 
   brunoerg commented at 8:57 PM on May 31, 2023: contributor

   Concept ACK

8. bitcoin deleted a comment on May 31, 2023
9. wallet: clarify replace fields in help output

   Closes #27781.

   d6f77ae573
10. torkelrogstad force-pushed on Jun 1, 2023
11. torkelrogstad renamed this:
    wallet: clarify replace fields in gettransaction
    wallet: clarify replace fields in help output
    on Jun 1, 2023
12. 
    torkelrogstad commented at 6:03 AM on June 1, 2023: contributor

    Thanks for pointing that out @brunoerg. Updated the commit message and PR title.

13. fanquake requested review from achow101 on Jun 5, 2023
14. torkelrogstad requested review from brunoerg on Jun 9, 2023
15. 
    luke-jr commented at 1:28 AM on June 24, 2023: member

    otoh, it would be nice to populate these when we detect a replaced receive tx...

16. in src/wallet/rpc/transactions.cpp:419 in d6f77ae573

     414 | @@ -415,8 +415,8 @@ static std::vector<RPCResult> TransactionDescriptionString()
     415 |             {
     416 |                 {RPCResult::Type::STR_HEX, "txid", "The transaction id."},
     417 |             }},
     418 | -           {RPCResult::Type::STR_HEX, "replaced_by_txid", /*optional=*/true, "The txid if this tx was replaced."},
     419 | -           {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "The txid if the tx replaces one."},
     420 | +           {RPCResult::Type::STR_HEX, "replaced_by_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if this tx was replaced."},
     421 | +           {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if the tx replaces one."},
    

    ---

    ---

    

    pinheadmz commented at 3:29 PM on July 24, 2023:

               {RPCResult::Type::STR_HEX, "replaces_txid", /*optional=*/true, "Only if 'category' is 'send'. The txid if this tx replaces another."},
    

17. 
    pinheadmz commented at 3:32 PM on July 24, 2023: member

    concept ACK

    Included a nit for better consistency with the messages. I'll also point out, regarding the original issue, that gettransaction also returns a walletconflicts field which is present for both senders and receivers.

18. 
    brunoerg commented at 11:21 AM on September 23, 2023: contributor

    Are you still working on it?

19. DrahtBot added the label CI failed on Oct 25, 2023
20. 
    maflcko commented at 1:30 PM on November 13, 2023: member

    Closing as up for grabs for now, due to lack of reply

21. maflcko closed this on Nov 13, 2023

    ---

22. bitcoin locked this on Nov 12, 2024

Contributors

torkelrogstadDrahtBotbrunoergluke-jrpinheadmzmaflcko

Review Requested
achow101brunoerg