Some people keep thinking that you need to download the full 4GB of Xcode before running xcode-select. However xcode-select is already present on any freshly installed macOS.
doc: clarify full Xcode download is not needed #27835
pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2023/06/no-need-xcode changing 1 files +3 −0-
Sjors commented at 3:30 PM on June 7, 2023: member
-
DrahtBot commented at 3:30 PM on June 7, 2023: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
- DrahtBot added the label Docs on Jun 7, 2023
-
grdddj commented at 3:31 PM on June 7, 2023: none
LGTM!
- maflcko requested review from fanquake on Jun 7, 2023
-
maflcko commented at 4:52 PM on June 7, 2023: member
Not sure if this is needed? Anyone to copy-paste the command shouldn't run into issues and if you do random other stuff, you are on your own anyway?
-
in doc/build-osx.md:20 in 39052a0342 outdated
16 | @@ -17,6 +17,7 @@ macOS comes with a built-in Terminal located in: 17 | 18 | The Xcode Command Line Tools are a collection of build tools for macOS. 19 | These tools must be installed in order to build Bitcoin Core from source. 20 | +You do not need to install all of Xcode.
brunoerg commented at 8:05 PM on June 7, 2023:Seems weird to say "you don't need to install" and the next line "To install, run...". If we want to advertise something, I prefer something like: "Recent MacOS versions may contain Xcode by default"
Sjors commented at 2:08 PM on June 8, 2023:macOS does not ship with all of Xcode, but they do ship with the
xcode-selectcommand.doc: clarify full Xcode download is not needed 29be2d24b0Sjors commented at 2:07 PM on June 8, 2023: memberSome background, it should indeed not be necessary to install Xcode: https://www.freecodecamp.org/news/install-xcode-command-line-tools/
I improved the prose a bit.
Sjors force-pushed on Jun 8, 2023DrahtBot added the label CI failed on Jun 8, 2023DrahtBot removed the label CI failed on Jun 9, 2023fanquake commented at 11:09 AM on June 13, 2023: memberSome background, it should indeed not be necessary to install Xcode:
It hasn't been required for at least 7 years, that's why we removed the instructions to install in: https://github.com/bitcoin/bitcoin/commit/2692e1b10bd7a0be644ed8a69c54152bc741e855.
fanquake commented at 1:21 PM on June 15, 2023: memberNot sure if this is needed? Anyone to copy-paste the command shouldn't run into issues and if you do random other stuff, you are on your own anyway?
Agree with the above. Not sure where the confusion is coming from, and, as mentioned, this hasn't be required for at least 7 years, if not longer than that. Anyone who is following this guide, and just copy-pasting commands, shouldn't be accidently going to the macOS App Store and downloading the ~8GB Xcode app bundle.
fanquake closed this on Jun 15, 2023Sjors deleted the branch on Jun 15, 2023bitcoin locked this on Jun 14, 2024
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 09:13 UTC
More mirrored repositories can be found on mirror.b10c.me