lint: suppress pip spam #27871

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:suppress_lint_spam changing 1 files +2 −0

fanquake commented at 11:05 AM on June 13, 2023: member

WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
WARNING: You are using pip version 22.0.4; however, version 23.1.2 is available.
You should consider upgrading via the '/tmp/python/bin/python3.8 -m pip install --upgrade pip' command.

Fix this by upgrading pip as part of install. Ignore the irrelevant "root user" output.

DrahtBot commented at 11:05 AM on June 13, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
in ci/lint/04_install.sh:38 in 7eac66d5ce outdated
```
  34 | @@ -33,6 +35,7 @@ if [ -z "${SKIP_PYTHON_INSTALL}" ]; then
  35 |      python3 --version
  36 |  fi
  37 |  
  38 | +${CI_RETRY_EXE} /tmp/python/bin/python3.8 -m pip install --upgrade pip
```
maflcko commented at 11:20 AM on June 13, 2023:

not sure about another place to hardcode the python version, especially if the only reason is to silence a simple single warning.

If you want the warning to be printed less often, you can modify the lines below to be a single call to pip, instead of multiple.

fanquake commented at 10:33 AM on June 14, 2023:

Just dropped the second commit for now.
DrahtBot added the label CI failed on Jun 13, 2023
lint: ignore pip root user usage spam c4f216ded1
fanquake force-pushed on Jun 14, 2023
in ci/lint/04_install.sh:9 in c4f216ded1
```
   5 | @@ -6,6 +6,8 @@
   6 |  
   7 |  export LC_ALL=C
   8 |  
   9 | +export PIP_ROOT_USER_ACTION=ignore
```
maflcko commented at 10:39 AM on June 14, 2023:

I don't think the warning is worth it to be ignored. There are hundreds of lines printed anyway for installing packages so removing one line, which is a warning doesn't seem too useful?

Again, if you want to print less lines, I think you can just combine the pip calls into one instead of doing this change.
maflcko commented at 10:43 AM on June 14, 2023:

Also, if there was any value in removing lines, you can fix the typos to remove three lines:

src/addrdb.cpp:213: unneccessary ==> unnecessary src/test/miniminer_tests.cpp:466: indeces ==> indices src/test/miniminer_tests.cpp:467: indeces ==> indices
fanquake closed this on Jun 14, 2023
fanquake deleted the branch on Jun 14, 2023
bitcoin locked this on Jun 13, 2024

Contributors

Labels

lint: suppress pip spam #27871

Reviews