test: refactoring test in rpc_generate.py #27878

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:test/generateblock/invalidtx changing 1 files +1 −1
  1. kevkevinpal commented at 12:07 AM on June 14, 2023: contributor

    There was a rpc assertation that only asserted part of the message. The additional untested text (". Make sure the tx has at least one input.") has been added

    Line of code that this refactor is testing https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/src/rpc/mining.cpp#L350

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. test: refactoring test in rpc_generate.py
    There was a rpc assertation that only asserted part of the message. The
    additional untested text (". Make sure the tx has at least one
    input.") has been added
    3c992adf1f
  3. DrahtBot commented at 12:07 AM on June 14, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. DrahtBot added the label Tests on Jun 14, 2023
  5. DrahtBot added the label CI failed on Jun 14, 2023
  6. jonatack commented at 9:12 PM on June 14, 2023: contributor

    According to git blame, this additional text was added in commit 33330778230961cfbf2a24de36b5877e395cc596 in #19836, in several different error messages.

    Running git grep "has at least one input" shows that none of them have tests that assert for that specific additional text.

    Per git grep "TX decode failed\|Transaction decode failed" test/functional/ if your change were to be done, it might make sense to update the other test assertions at the same time.

    OTOH when tests are checking for the existence of the error message, i.e. that the error was raised, and not the exact form of the message, it could be argued that there's little benefit.

  7. kevkevinpal commented at 10:40 PM on June 15, 2023: contributor

    According to git blame, this additional text was added in commit 3333077 in #19836, in several different error messages.

    Running git grep "has at least one input" shows that none of them have tests that assert for that specific additional text.

    Per git grep "TX decode failed\|Transaction decode failed" test/functional/ if your change were to be done, it might make sense to update the other test assertions at the same time.

    OTOH when tests are checking for the existence of the error message, i.e. that the error was raised, and not the exact form of the message, it could be argued that there's little benefit.

    That's a good point since we already check for the existence of the error I think its best to close this PR

  8. kevkevinpal closed this on Jun 15, 2023

  9. bitcoin locked this on Jun 14, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me