test: Fuzz on macOS #27932

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2306-fuzz-mac- changing 4 files +21 −13

maflcko commented at 9:31 AM on June 22, 2023: member

Any reason not to?
DrahtBot commented at 9:31 AM on June 22, 2023: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK jamesob, dergoegge

Concept ACK brunoerg, kevkevinpal

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Jun 22, 2023
maflcko renamed this:
~~test: Run fuzz tests on macOS~~
test: Run fuzz on macOS
on Jun 22, 2023
maflcko renamed this:
~~test: Run fuzz on macOS~~
test: Fuzz on macOS
on Jun 22, 2023

Type	Reviewers
ACK	jamesob, dergoegge
Concept ACK	brunoerg, kevkevinpal

maflcko commented at 9:58 AM on June 22, 2023: member

Looks like this fails https://cirrus-ci.com/task/6065266690359296?logs=ci#L3616

Run banman with args ['/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-arm64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman')]Assertion failed: (banmap == banmap_read), function banman_fuzz_target, file banman.cpp, line 112.
Error processing input "/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman/f02775f613ebc1b9ff595d4b3129407deac65bfc"
Assertion failed: (banmap == banmap_read), function banman_fuzz_target, file banman.cpp, line 112.
Error processing input "/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman/f02775f613ebc1b9ff595d4b3129407deac65bfc"
Target ['/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/build/bitcoin-arm64-apple-darwin/src/test/fuzz/fuzz', PosixPath('/private/var/folders/s0/b8snf7qj1479hhmzr90n5s4m0000gn/T/cirrus-ci-build/ci/scratch/qa-assets/fuzz_seed_corpus/banman')] failed with exit code 1

maflcko force-pushed on Jun 22, 2023
DrahtBot added the label CI failed on Jun 22, 2023
dergoegge commented at 10:15 AM on June 22, 2023: member

Concept ACK

Would there be any value in making this a separate task?
brunoerg commented at 10:16 AM on June 22, 2023: contributor

Concept ACK
maflcko force-pushed on Jun 22, 2023

test: Run fuzz tests on macOS

Also, fix a few bugs:

* Error: RPC command "enumeratesigners" not found in RPC_COMMANDS_SAFE_FOR_FUZZING or RPC_COMMANDS_NOT_SAFE_FOR_FUZZING. Please update test/fuzz/rpc.cpp.
* in run_once: ...format(" ".join(result.args), ... TypeError: sequence item 2: expected str instance, PosixPath found

fae7c50d20

maflcko force-pushed on Jun 22, 2023
DrahtBot removed the label CI failed on Jun 22, 2023
maflcko commented at 1:00 PM on June 22, 2023: member

Would there be any value in making this a separate task?

Not unless there is a benefit.
kevkevinpal commented at 6:39 PM on June 22, 2023: contributor

Concept ACK
jamesob approved
jamesob commented at 4:45 PM on June 28, 2023: member

Github ACK https://github.com/bitcoin/bitcoin/pull/27932/commits/fae7c50d201726f605938c3511dd9119efeea5ec

Adds fuzzing to a new architecture, right? Seems like an easy win?
dergoegge approved
dergoegge commented at 11:58 AM on June 29, 2023: member

utACK fae7c50d201726f605938c3511dd9119efeea5ec
fanquake merged this on Jun 29, 2023
fanquake closed this on Jun 29, 2023
maflcko deleted the branch on Jun 29, 2023
sidhujag referenced this in commit ffaac29d8f on Jun 30, 2023
bitcoin locked this on Jun 28, 2024

Contributors

Labels

test: Fuzz on macOS #27932

Reviews