This avoids spurious errors with the old tests but still tests enough that if the rng is replaced with a totally broken one it should still fail.
Make the rand tests determinstic. #2796
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:remove_overactive_rand_tests changing 1 files +1 −33-
gmaxwell commented at 7:10 PM on June 25, 2013: contributor
-
TheBlueMatt commented at 12:57 PM on July 7, 2013: member
Huh? The removes the tests that are deterministic and leaves only the ones that cause spurious errors on pull-tester every once in a while.
-
gmaxwell commented at 3:03 PM on July 7, 2013: contributor
@TheBlueMatt No it doesn't. I promise.
-
TheBlueMatt commented at 3:09 PM on July 7, 2013: member
Ahhh, yes...can you add (fixes #2714) to the commit message so it gets closed on merge?
-
TheBlueMatt commented at 4:53 PM on July 7, 2013: member
ACK
-
e5c4dfdfc0
Make the rand tests determinstic. (fixes #2714)
This avoids spurious errors with the old tests but still tests enough that if the rng is replaced with a totally broken one it should still fail.
- gmaxwell referenced this in commit 204b8af6dc on Jul 7, 2013
- gmaxwell merged this on Jul 7, 2013
- gmaxwell closed this on Jul 7, 2013
- Bushstar referenced this in commit 02db06658e on Apr 5, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors