ci: filter all subtrees from tidy output #27996

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:bear_exclude_minisketch changing 2 files +6 −3
  1. fanquake commented at 9:43 AM on June 29, 2023: member

    We are currently dumping output for some. i.e:

    diff --git a/src/minisketch/src/fields/clmul_1byte.cpp b/src/minisketch/src/fields/clmul_1byte.cpp
    index 8826af9..7fd6f2a 100644
    --- a/src/minisketch/src/fields/clmul_1byte.cpp
    +++ b/src/minisketch/src/fields/clmul_1byte.cpp
    @@ -4,21 +4,16 @@
      * file LICENSE or http://www.opensource.org/licenses/mit-license.php.*
      **********************************************************************/
    
    -/* This file was substantially auto-generated by doc/gen_params.sage. */
    -#include "../fielddefines.h"
    -
    +class Sketch;
     #if defined(ENABLE_FIELD_BYTES_INT_1)
    
  2. DrahtBot commented at 9:43 AM on June 29, 2023: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto
    Stale ACK MarcoFalke

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Tests on Jun 29, 2023
  4. maflcko commented at 10:09 AM on June 29, 2023: member

    lgtm ACK ce377a0a230d4cefdf03a6c183377fde52cf8f81

  5. hebasto approved
  6. hebasto commented at 10:35 AM on June 29, 2023: member

    ACK ce377a0a230d4cefdf03a6c183377fde52cf8f81, I have reviewed the code and it looks OK.

  7. in src/.bear-tidy-config:7 in ce377a0a23 outdated
       3 | @@ -4,7 +4,10 @@
       4 |        "include_only_existing_source": true,
       5 |        "paths_to_include": [],
       6 |        "paths_to_exclude": [
       7 | -        "src/leveldb"
       8 | +        "src/crc32c",
    


    hebasto commented at 10:38 AM on June 29, 2023:
            "src/crc32c",
            "src/crypto/ctaes",
    
  8. ci: filter all subtrees from tidy output
    We are currently dumping output for some. i.e:
    ```bash
    diff --git a/src/minisketch/src/fields/clmul_1byte.cpp b/src/minisketch/src/fields/clmul_1byte.cpp
    index 8826af9..7fd6f2a 100644
    --- a/src/minisketch/src/fields/clmul_1byte.cpp
    +++ b/src/minisketch/src/fields/clmul_1byte.cpp
    @@ -4,21 +4,16 @@
      * file LICENSE or http://www.opensource.org/licenses/mit-license.php.*
      **********************************************************************/
    
    -/* This file was substantially auto-generated by doc/gen_params.sage. */
    -#include "../fielddefines.h"
    -
    +class Sketch;
     #if defined(ENABLE_FIELD_BYTES_INT_1)
    ```
    62633b5046
  9. fanquake force-pushed on Jun 29, 2023
  10. hebasto approved
  11. hebasto commented at 12:18 PM on June 29, 2023: member

    re-ACK 62633b50461cb67dfb37d6485e604152e727559c

  12. DrahtBot requested review from maflcko on Jun 29, 2023
  13. fanquake merged this on Jun 29, 2023
  14. fanquake closed this on Jun 29, 2023

  15. fanquake deleted the branch on Jun 29, 2023
  16. sidhujag referenced this in commit 65b3bc10c9 on Jun 30, 2023
  17. bitcoin locked this on Jun 28, 2024


maflcko

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me